From: Daniel Vetter Subject: Re: [PATCH 2/2] drm: Set crc->opened = false before setting crc source to NULL. Date: Fri, 21 Jun 2019 17:46:09 +0200 Message-ID: <20190621154609.GF12905@phenom.ffwll.local> References: <20190605170639.8368-1-dingchen.zhang@amd.com> <20190605170639.8368-2-dingchen.zhang@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 532B66E8E4 for ; Fri, 21 Jun 2019 15:46:18 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id k21so10755464edq.3 for ; Fri, 21 Jun 2019 08:46:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Harry Wentland Cc: "Zhang, Dingchen (David)" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKdW4gMjEsIDIwMTkgYXQgMDI6MjE6NDNQTSArMDAwMCwgSGFycnkgV2VudGxhbmQg d3JvdGU6Cj4gT24gMjAxOS0wNi0wNSAxOjA2IHAubS4sIERpbmdjaGVuIFpoYW5nIHdyb3RlOgo+ ID4gdG8gdGVybWluYXRlIHRoZSB3aGlsZS1sb29wIGluIGRybV9kcF9hdXhfY3JjX3dvcmsgd2hl biBkcm1fZHBfc3RhcnQvc3RvcF9jcmMKPiA+IGFyZSBjYWxsZWQgaW4gdGhlIGhvb2sgdG8gc2V0 IGNyYyBzb3VyY2UuCj4gPiAKPiA+IENjOkxlbyBMaSA8c3VucGVuZy5saUBhbWQuY29tPiwgSGFy cnkgPEhhcnJ5LldlbnRsYW5kQGFtZC5jb20+LCBOaWNrIDxOaWNob2xhcy5LYXpsYXVza2FzQGFt ZC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBEaW5nY2hlbiBaaGFuZyA8ZGluZ2NoZW4uemhhbmdA YW1kLmNvbT4KPiAKPiBJIHdvbmRlciBob3cgdGhpcyBpc24ndCBjcmVhdGluZyBwcm9ibGVtcyBm b3IgUm9ja2NoaXAgd2l0aCB0aGUgQW5hbG9naXgKPiBicmlkZ2UuCj4gCj4gUmV2aWV3ZWQtYnk6 IEhhcnJ5IFdlbnRsYW5kIDxoYXJyeS53ZW50bGFuZEBhbWQuY29tPgo+IAo+IEhhcnJ5Cj4gCj4g PiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2RlYnVnZnNfY3JjLmMgfCA3ICsrKysrKysK PiA+ICAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspCj4gPiAKPiA+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vZHJtX2RlYnVnZnNfY3JjLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJt X2RlYnVnZnNfY3JjLmMKPiA+IGluZGV4IGUyMGFkZWY5ZDYyMy4uMGU4YmNjMTMwMzgzIDEwMDY0 NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9kZWJ1Z2ZzX2NyYy5jCj4gPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX2RlYnVnZnNfY3JjLmMKPiA+IEBAIC0yNDksNiArMjQ5LDEzIEBA IHN0YXRpYyBpbnQgY3J0Y19jcmNfcmVsZWFzZShzdHJ1Y3QgaW5vZGUgKmlub2RlLCBzdHJ1Y3Qg ZmlsZSAqZmlsZXApCj4gPiAgCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9IGZpbGVwLT5mX2lub2Rl LT5pX3ByaXZhdGU7Cj4gPiAgCXN0cnVjdCBkcm1fY3J0Y19jcmMgKmNyYyA9ICZjcnRjLT5jcmM7 Cj4gPiAgCj4gPiArCS8qIHRlcm1pbmF0ZSB0aGUgaW5maW5pdGUgd2hpbGUgbG9vcCBpZiAnZHJt X2RwX2F1eF9jcmNfd29yaycgcnVubmluZyAqLwo+ID4gKwlpZiAoY3JjLT5vcGVuZWQpIHsKPiA+ ICsJCXNwaW5fbG9ja19pcnEoJmNyYy0+bG9jayk7Cj4gPiArCQljcmMtPm9wZW5lZCA9IGZhbHNl Owo+ID4gKwkJc3Bpbl91bmxvY2tfaXJxKCZjcmMtPmxvY2spOwo+ID4gKwl9CgpFaXRoZXIgeW91 IGRvbid0IG5lZWQgYSBsb2NrIHRvIGxvb2sgYXQgLT5vcGVuZWQsIG9yIHlvdSBuZWVkIGl0LiBO b3QKYm90aC4gVG9vIGxhenkgY2hlY2sgd2hpY2ggd2F5IHRoaXMgaXMsIGl0J3MgcHJhY3RpY2Fs bHkgdy9lIGhlcmUgOi0pCi1EYW5pZWwKCj4gPiArCj4gPiAgCWNydGMtPmZ1bmNzLT5zZXRfY3Jj X3NvdXJjZShjcnRjLCBOVUxMKTsKPiA+ICAKPiA+ICAJc3Bpbl9sb2NrX2lycSgmY3JjLT5sb2Nr KTsKPiA+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0 aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbA==