Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD494C43613 for ; Mon, 24 Jun 2019 03:20:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEB60208C3 for ; Mon, 24 Jun 2019 03:20:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Asji/hB1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727487AbfFXDUh (ORCPT ); Sun, 23 Jun 2019 23:20:37 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:51424 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726307AbfFXDUh (ORCPT ); Sun, 23 Jun 2019 23:20:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cKhx+mIkeviKG/DThCrqSVmM2QsoZLdSj4JyxKOm2Nc=; b=Asji/hB11NpdaFHz3ak6u9p1DJ tudqAtcBQlsjCSZ/SgJRdOE1msPKypO8O4VMmna19zcdlcjgiwnoCE3QCXrBwWbwBY5o0J0l7du8/ YLVAILY2qT8/xO3+BsRWLqMiGQxxQyu4sW/k3g46MQERW1i/0KBjFvGWQ+1HqLzh+Ids=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hfFX2-0002Tf-Es; Mon, 24 Jun 2019 05:20:36 +0200 Date: Mon, 24 Jun 2019 05:20:36 +0200 From: Andrew Lunn To: Marek Vasut Cc: netdev@vger.kernel.org, Florian Fainelli , Tristram Ha , Woojung Huh Subject: Re: [PATCH V3 05/10] net: dsa: microchip: Use PORT_CTRL_ADDR() instead of indirect function call Message-ID: <20190624032036.GL28942@lunn.ch> References: <20190623223508.2713-1-marex@denx.de> <20190623223508.2713-6-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190623223508.2713-6-marex@denx.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 24, 2019 at 12:35:03AM +0200, Marek Vasut wrote: > The indirect function call to dev->dev_ops->get_port_addr() is expensive > especially if called for every single register access, and only returns > the value of PORT_CTRL_ADDR() macro. Use PORT_CTRL_ADDR() macro directly > instead. Hi Marek Rather than change just one instance, it would be better to change them all. And then remove dev_ops->get_port_addr(). Andrew