Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E93A2C43613 for ; Mon, 24 Jun 2019 08:47:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C5549208CA for ; Mon, 24 Jun 2019 08:47:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727344AbfFXIrH (ORCPT ); Mon, 24 Jun 2019 04:47:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:45142 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726690AbfFXIrH (ORCPT ); Mon, 24 Jun 2019 04:47:07 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2F1C4AE76; Mon, 24 Jun 2019 08:47:06 +0000 (UTC) From: Oliver Neukum To: johan@kernel.org, linux-usb@vger.kernel.org Cc: Oliver Neukum Subject: [PATCH] gpss: core: no waiters left behind on deregister Date: Mon, 24 Jun 2019 10:33:23 +0200 Message-Id: <20190624083323.11876-1-oneukum@suse.com> X-Mailer: git-send-email 2.16.4 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org If you deregister a device you need to wake up all waiters as there will be no further wakeups. Signed-off-by: Oliver Neukum --- drivers/gnss/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gnss/core.c b/drivers/gnss/core.c index e6f94501cb28..0d13bd2cefd5 100644 --- a/drivers/gnss/core.c +++ b/drivers/gnss/core.c @@ -303,7 +303,7 @@ void gnss_deregister_device(struct gnss_device *gdev) down_write(&gdev->rwsem); gdev->disconnected = true; if (gdev->count) { - wake_up_interruptible(&gdev->read_queue); + wake_up_interruptible_all(&gdev->read_queue); gdev->ops->close(gdev); } up_write(&gdev->rwsem); -- 2.16.4