From: Peter Zijlstra Date: Tue, 25 Jun 2019 15:27:36 +0200 Subject: [Cluster-devel] [RFC][PATCH] wake_up_var() memory ordering In-Reply-To: References: <20190624165012.GH3436@hirez.programming.kicks-ass.net> <20190625103430.GW3402@hirez.programming.kicks-ass.net> Message-ID: <20190625132736.GZ3419@hirez.programming.kicks-ass.net> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Jun 25, 2019 at 02:12:22PM +0200, Andreas Gruenbacher wrote: > > Only if we do as David suggested and make clean_and_wake_up_bit() > > provide the RELEASE barrier. > > (It's clear_and_wake_up_bit, not clean_and_wake_up_bit.) Yes, typing hard. > > That is, currently clear_and_wake_up_bit() is > > > > clear_bit() > > smp_mb__after_atomic(); > > wake_up_bit(); > > > Now I'm confused because clear_and_wake_up_bit() in mainline does use > clear_bit_unlock(), so it's the exact opposite of what you just said. Argh; clearly I couldn't read. And then yes, you're right.