Received: from list by lists.gnu.org with archive (Exim 4.86_2) id 1hgFqr-00032D-8x for mharc-qemu-trivial@gnu.org; Wed, 26 Jun 2019 17:53:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33654) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgFqp-0002zT-5E for qemu-trivial@nongnu.org; Wed, 26 Jun 2019 17:53:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgFqo-00057L-4Y for qemu-trivial@nongnu.org; Wed, 26 Jun 2019 17:53:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50964) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hgFqj-00052x-PZ; Wed, 26 Jun 2019 17:53:05 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B86F98553B; Wed, 26 Jun 2019 21:53:04 +0000 (UTC) Received: from probe.bos.redhat.com (dhcp-17-47.bos.redhat.com [10.18.17.47]) by smtp.corp.redhat.com (Postfix) with ESMTP id C6F601001E63; Wed, 26 Jun 2019 21:53:01 +0000 (UTC) From: John Snow To: qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: Qemu-Trivial , Max Reitz , Kevin Wolf , John Snow , radmehrsaeed7@gmail.com Date: Wed, 26 Jun 2019 17:53:01 -0400 Message-Id: <20190626215301.30733-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 26 Jun 2019 21:53:04 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-trivial] [PATCH] block/qcow: Improve error when opening qcow2 files as qcow X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jun 2019 21:53:12 -0000 Reported-by: radmehrsaeed7@gmail.com Fixes: https://bugs.launchpad.net/bugs/1832914 Signed-off-by: John Snow --- block/qcow.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/block/qcow.c b/block/qcow.c index 6dee5bb792..a9cb6ae0bd 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -156,7 +156,12 @@ static int qcow_open(BlockDriverState *bs, QDict *op= tions, int flags, goto fail; } if (header.version !=3D QCOW_VERSION) { - error_setg(errp, "Unsupported qcow version %" PRIu32, header.ver= sion); + error_setg(errp, "qcow (v%d) does not support qcow version %" PR= Iu32, + QCOW_VERSION, header.version); + if (header.version =3D=3D 2 || header.version =3D=3D 3) { + error_append_hint(errp, "Try the 'qcow2' driver instead."); + } + ret =3D -ENOTSUP; goto fail; } --=20 2.21.0