From: Luis Henriques Subject: [RFC PATCH] ceph: initialize superblock s_time_gran to 1 Date: Thu, 27 Jun 2019 14:51:22 +0100 Message-ID: <20190627135122.12817-1-lhenriques@suse.com> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: Sender: linux-kernel-owner@vger.kernel.org To: Jeff Layton , "Yan, Zheng" , Sage Weil , Ilya Dryomov Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Henriques List-Id: ceph-devel.vger.kernel.org Having granularity set to 1us results in having inode timestamps with a accurancy different from the fuse client (i.e. atime, ctime and mtime will always end with '000'). This patch normalizes this behaviour and sets the granularity to 1. Signed-off-by: Luis Henriques --- fs/ceph/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Hi! As far as I could see there are no other side-effects of changing s_time_gran but I'm really not sure why it was initially set to 1000 in the first place so I may be missing something. diff --git a/fs/ceph/super.c b/fs/ceph/super.c index d57fa60dcd43..35dd75bc9cd0 100644 --- a/fs/ceph/super.c +++ b/fs/ceph/super.c @@ -980,7 +980,7 @@ static int ceph_set_super(struct super_block *s, void *data) s->s_d_op = &ceph_dentry_ops; s->s_export_op = &ceph_export_ops; - s->s_time_gran = 1000; /* 1000 ns == 1 us */ + s->s_time_gran = 1; ret = set_anon_super(s, NULL); /* what is that second arg for? */ if (ret != 0)