Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:46288 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726431AbfF0Ojx (ORCPT ); Thu, 27 Jun 2019 10:39:53 -0400 From: Christoph Hellwig Subject: [PATCH] xfs: fix iclog allocation size Date: Thu, 27 Jun 2019 16:39:50 +0200 Message-Id: <20190627143950.19558-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: linux-xfs@vger.kernel.org Cc: syzbot+b75afdbe271a0d7ac4f6@syzkaller.appspotmail.com Properly allocate the space for the bio_vecs instead of just one byte per bio_vec. Fixes: 991fc1d2e65e ("xfs: use bios directly to write log buffers") Reported-by: syzbot+b75afdbe271a0d7ac4f6@syzkaller.appspotmail.com Signed-off-by: Christoph Hellwig --- fs/xfs/xfs_log.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c index 0f849b4095d6..e230f3c18ceb 100644 --- a/fs/xfs/xfs_log.c +++ b/fs/xfs/xfs_log.c @@ -1415,7 +1415,8 @@ xlog_alloc_log( */ ASSERT(log->l_iclog_size >= 4096); for (i = 0; i < log->l_iclog_bufs; i++) { - size_t bvec_size = howmany(log->l_iclog_size, PAGE_SIZE); + size_t bvec_size = howmany(log->l_iclog_size, PAGE_SIZE) * + sizeof(struct bio_vec); iclog = kmem_zalloc(sizeof(*iclog) + bvec_size, KM_MAYFAIL); if (!iclog) -- 2.20.1