From: Alexander Dahl Date: Fri, 28 Jun 2019 14:41:21 +0200 Subject: [U-Boot] [PATCH v2 2/5] fpga: altera: cyclon2: Fix most checkpatch warnings In-Reply-To: <20190628124124.14706-1-ada@thorsis.com> References: <20190628124124.14706-1-ada@thorsis.com> Message-ID: <20190628124124.14706-3-ada@thorsis.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de Nothing special, but done before further cleanup. * spacing * braces * __FUNCTION__ =E2=86=92 __func__ Suggested-by: Michal Simek Signed-off-by: Alexander Dahl --- drivers/fpga/cyclon2.c | 81 ++++++++++++++++++++++++----------------------= ---- 1 file changed, 39 insertions(+), 42 deletions(-) diff --git a/drivers/fpga/cyclon2.c b/drivers/fpga/cyclon2.c index 6755956e85..99a64d437c 100644 --- a/drivers/fpga/cyclon2.c +++ b/drivers/fpga/cyclon2.c @@ -11,9 +11,9 @@ =20 /* Define FPGA_DEBUG to get debug printf's */ #ifdef FPGA_DEBUG -#define PRINTF(fmt,args...) printf (fmt ,##args) +#define PRINTF(fmt, args...) printf(fmt, ##args) #else -#define PRINTF(fmt,args...) +#define PRINTF(fmt, args...) #endif =20 /* Note: The assumption is that we cannot possibly run fast enough to @@ -26,7 +26,7 @@ #endif =20 #ifndef CONFIG_SYS_FPGA_WAIT -#define CONFIG_SYS_FPGA_WAIT CONFIG_SYS_HZ/10 /* 100 ms */ +#define CONFIG_SYS_FPGA_WAIT CONFIG_SYS_HZ / 10 /* 100 ms */ #endif =20 static int CYC2_ps_load(Altera_desc *desc, const void *buf, size_t bsize); @@ -41,8 +41,8 @@ int CYC2_load(Altera_desc *desc, const void *buf, size_t = bsize) =20 switch (desc->iface) { case passive_serial: - PRINTF ("%s: Launching Passive Serial Loader\n", __FUNCTION__); - ret_val =3D CYC2_ps_load (desc, buf, bsize); + PRINTF("%s: Launching Passive Serial Loader\n", __func__); + ret_val =3D CYC2_ps_load(desc, buf, bsize); break; =20 case fast_passive_parallel: @@ -50,16 +50,16 @@ int CYC2_load(Altera_desc *desc, const void *buf, size_= t bsize) * done in the write() callback. Use the existing PS load * function for FPP, too. */ - PRINTF ("%s: Launching Fast Passive Parallel Loader\n", - __FUNCTION__); + PRINTF("%s: Launching Fast Passive Parallel Loader\n", + __func__); ret_val =3D CYC2_ps_load(desc, buf, bsize); break; =20 /* Add new interface types here */ =20 default: - printf ("%s: Unsupported interface type, %d\n", - __FUNCTION__, desc->iface); + printf("%s: Unsupported interface type, %d\n", + __func__, desc->iface); } =20 return ret_val; @@ -71,59 +71,58 @@ int CYC2_dump(Altera_desc *desc, const void *buf, size_= t bsize) =20 switch (desc->iface) { case passive_serial: - PRINTF ("%s: Launching Passive Serial Dump\n", __FUNCTION__); - ret_val =3D CYC2_ps_dump (desc, buf, bsize); + PRINTF("%s: Launching Passive Serial Dump\n", __func__); + ret_val =3D CYC2_ps_dump(desc, buf, bsize); break; =20 /* Add new interface types here */ =20 default: - printf ("%s: Unsupported interface type, %d\n", - __FUNCTION__, desc->iface); + printf("%s: Unsupported interface type, %d\n", + __func__, desc->iface); } =20 return ret_val; } =20 -int CYC2_info( Altera_desc *desc ) +int CYC2_info(Altera_desc *desc) { return FPGA_SUCCESS; } =20 /* -----------------------------------------------------------------------= -- */ -/* CYCLON2 Passive Serial Generic Implementation = */ +/* CYCLON2 Passive Serial Generic Implementation = */ static int CYC2_ps_load(Altera_desc *desc, const void *buf, size_t bsize) { int ret_val =3D FPGA_FAIL; /* assume the worst */ Altera_CYC2_Passive_Serial_fns *fn =3D desc->iface_fns; int ret =3D 0; =20 - PRINTF ("%s: start with interface functions @ 0x%p\n", - __FUNCTION__, fn); + PRINTF("%s: start with interface functions @ 0x%p\n", + __func__, fn); =20 if (fn) { int cookie =3D desc->cookie; /* make a local copy */ unsigned long ts; /* timestamp */ =20 - PRINTF ("%s: Function Table:\n" + PRINTF("%s: Function Table:\n" "ptr:\t0x%p\n" "struct: 0x%p\n" "config:\t0x%p\n" "status:\t0x%p\n" "write:\t0x%p\n" "done:\t0x%p\n\n", - __FUNCTION__, &fn, fn, fn->config, fn->status, + __func__, &fn, fn, fn->config, fn->status, fn->write, fn->done); #ifdef CONFIG_SYS_FPGA_PROG_FEEDBACK - printf ("Loading FPGA Device %d...", cookie); + printf("Loading FPGA Device %d...", cookie); #endif =20 /* * Run the pre configuration function if there is one. */ - if (*fn->pre) { + if (*fn->pre) (*fn->pre) (cookie); - } =20 /* Establish the initial state */ (*fn->config) (false, true, cookie); /* De-assert nCONFIG */ @@ -133,22 +132,23 @@ static int CYC2_ps_load(Altera_desc *desc, const void= *buf, size_t bsize) udelay(2); /* T_cfg > 2us */ =20 /* Wait for nSTATUS to be asserted */ - ts =3D get_timer (0); /* get current time */ + ts =3D get_timer(0); /* get current time */ do { - CONFIG_FPGA_DELAY (); - if (get_timer (ts) > CONFIG_SYS_FPGA_WAIT) { /* check the time */ - puts ("** Timeout waiting for STATUS to go high.\n"); + CONFIG_FPGA_DELAY(); + if (get_timer(ts) > CONFIG_SYS_FPGA_WAIT) { + /* check the time */ + puts("** Timeout waiting for STATUS to go high.\n"); (*fn->abort) (cookie); return FPGA_FAIL; } } while (!(*fn->status) (cookie)); =20 /* Get ready for the burn */ - CONFIG_FPGA_DELAY (); + CONFIG_FPGA_DELAY(); =20 ret =3D (*fn->write) (buf, bsize, true, cookie); if (ret) { - puts ("** Write failed.\n"); + puts("** Write failed.\n"); (*fn->abort) (cookie); return FPGA_FAIL; } @@ -156,20 +156,20 @@ static int CYC2_ps_load(Altera_desc *desc, const void= *buf, size_t bsize) puts(" OK? ..."); #endif =20 - CONFIG_FPGA_DELAY (); + CONFIG_FPGA_DELAY(); =20 #ifdef CONFIG_SYS_FPGA_PROG_FEEDBACK - putc (' '); /* terminate the dotted line */ + putc(' '); /* terminate the dotted line */ #endif =20 /* * Checking FPGA's CONF_DONE signal - correctly booted ? */ =20 - if ( ! (*fn->done) (cookie) ) { - puts ("** Booting failed! CONF_DONE is still deasserted.\n"); + if (!(*fn->done) (cookie)) { + puts("** Booting failed! CONF_DONE is still deasserted.\n"); (*fn->abort) (cookie); - return (FPGA_FAIL); + return FPGA_FAIL; } #ifdef CONFIG_SYS_FPGA_PROG_FEEDBACK puts(" OK\n"); @@ -178,17 +178,15 @@ static int CYC2_ps_load(Altera_desc *desc, const void= *buf, size_t bsize) ret_val =3D FPGA_SUCCESS; =20 #ifdef CONFIG_SYS_FPGA_PROG_FEEDBACK - if (ret_val =3D=3D FPGA_SUCCESS) { - puts ("Done.\n"); - } - else { - puts ("Fail.\n"); - } + if (ret_val =3D=3D FPGA_SUCCESS) + puts("Done.\n"); + else + puts("Fail.\n"); #endif (*fn->post) (cookie); =20 } else { - printf ("%s: NULL Interface function table!\n", __FUNCTION__); + printf("%s: NULL Interface function table!\n", __func__); } =20 return ret_val; @@ -198,7 +196,6 @@ static int CYC2_ps_dump(Altera_desc *desc, const void *= buf, size_t bsize) { /* Readback is only available through the Slave Parallel and */ /* boundary-scan interfaces. */ - printf ("%s: Passive Serial Dumping is unavailable\n", - __FUNCTION__); + printf("%s: Passive Serial Dumping is unavailable\n", __func__); return FPGA_FAIL; } --=20 2.11.0