From: Russell King - ARM Linux admin Subject: Re: [PATCH] drm/armada: fix debugfs link error Date: Fri, 28 Jun 2019 13:48:32 +0100 Message-ID: <20190628124832.cedpoabfiqgjhtkq@shell.armlinux.org.uk> References: <20190628103359.2516007-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190628103359.2516007-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: David Airlie , Daniel Vetter , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Fri, Jun 28, 2019 at 12:33:40PM +0200, Arnd Bergmann wrote: > Debugfs can be disabled at compile time, causing a link error > with the newly restructured code: > > drivers/gpu/drm/armada/armada_crtc.o: In function `armada_drm_crtc_late_register': > armada_crtc.c:(.text+0x974): undefined reference to `armada_drm_crtc_debugfs_init' > > Make the code into the debugfs init function conditional. Thanks Arnd, mind if I roll this into the original commit? > Fixes: 05ec8bd524ba ("drm/armada: redo CRTC debugfs files") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/armada/armada_crtc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/armada/armada_crtc.c b/drivers/gpu/drm/armada/armada_crtc.c > index e3a5964d8a65..03d3fd00fe00 100644 > --- a/drivers/gpu/drm/armada/armada_crtc.c > +++ b/drivers/gpu/drm/armada/armada_crtc.c > @@ -773,7 +773,9 @@ static void armada_drm_crtc_destroy(struct drm_crtc *crtc) > > static int armada_drm_crtc_late_register(struct drm_crtc *crtc) > { > - armada_drm_crtc_debugfs_init(drm_to_armada_crtc(crtc)); > + if (IS_ENABLED(CONFIG_DEBUG_FS)) > + armada_drm_crtc_debugfs_init(drm_to_armada_crtc(crtc)); > + > return 0; > } > > -- > 2.20.0 > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up