From: yang.bin18@zte.com.cn Date: Fri, 28 Jun 2019 15:44:50 +0800 (CST) Subject: [Cluster-devel] =?utf-8?q?=5BPATCH=5D_sub_sd=5Frgrps_When_clear_r?= =?utf-8?q?grp?= In-Reply-To: References: 1561604670-11476-1-git-send-email-yang.bin18@zte.com.cn, CAHpGcM+6p_TtHh=YSa1Mxyjr+w+V5_8RR2TgnN-s5TbbHjGhng@mail.gmail.com Message-ID: <201906281544509275975@zte.com.cn> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Andreas, >Am Do., 27. Juni 2019 um 05:08 Uhr schrieb Yang Bin : >> From: " Yang Bin " >> >> When clear rgrp,sub sd_rgrps after erased from rindex_tree >this patch isn't incorrect, but all it does it ensure that sd_rgrps >reaches zero before we destroy a struct gfs2_sbd. However, sd_rgrps is >only ever used when a filesystem is active, and while that is the >case, it can never decrease. It will grow when the filesystem is grown >though. >So what are you trying to achieve with this patch? In mounting, it may fail and then execute "gfs2_clear_rgrpd" . To solve this failing , I add reload process,which will read rindex again .But reload will fail , because sd_rgrps has beyonded rindex`s size. So I make this patch. >> Signed-off-by: Yang Bin >> --- >> fs/gfs2/rgrp.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c >> index 15d6e32..a4b2e83 >> --- a/fs/gfs2/rgrp.c >> +++ b/fs/gfs2/rgrp.c >> @@ -730,6 +730,7 @@ void gfs2_clear_rgrpd(struct gfs2_sbd *sdp) >> gl = rgd->rd_gl; >> >> rb_erase(n, &sdp->sd_rindex_tree); >> + sdp->sd_rgrps--; >> >> if (gl) { >> glock_clear_object(gl, rgd); >> -- >> 1.8.3.1 >> >Thanks, >Andreas