Received: by 2002:a5d:6790:0:0:0:0:0 with SMTP id v16csp2450562wru; Mon, 1 Jul 2019 02:37:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqxRmF4K5aljEa7zFzYadXnaNzOWNS6lE7ZrjXuzEgiGCLaak6I4+IPd9cp+orpjLxu1cVU5 X-Received: by 2002:a50:940b:: with SMTP id p11mr28444106eda.194.1561973838807; Mon, 01 Jul 2019 02:37:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561973838; cv=none; d=google.com; s=arc-20160816; b=AFYxe2Zlo0HaOZuni7YPQqpblfE/5LEP+8YnyQ2Av3UAr47nu1WR8Xq1LlP1M0UGzc kpw6YRjuplbS9BdZ2W9Oq9U5FRctvTxo3UeS49mF9jduGHF8ZY+vSqFJAl2r7jQKChRQ rgvu4LrSKgF+UDKg/9cOSbPXNjYGIypx3KtMjsKWfk4ELEz5TriOuNdES0qTnXOVjfF8 aJAKqK0xEYvQ88IYs6RKA5+ujllxYklhVLdaAo73QKShjDQFOVmj47D0No8o5UNM+5ef 19dIms2OmnU+nuIT8RCeB7rFBqi9TfZw+gMl/tKi48hW8JNO5Vb4eM7tVJelVRb/yltf Lbmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from; bh=MVJu2btcTzUrhl9VpUEdzdNYTSNyXFvdr6A1Rf0U81U=; b=N6DhbZVWa11NBgXub5+qEIF3jSFSuuuuRpACNPqbKaq5Kdd2D/IPlumixAD5Fo/a6g ekWXxUiu478IALiHZl8/EazaLRp3o6rznsUnd1jQSUyIAa+5c8C9EgI/ArA0bh5P7swL wQCRcB/u5JPorUu3zkdvey9aflVY0ocqGrz+39CyxnxtAD2ffZvIkhe5R2JNilwNUYlR j+pAqK+5AsxTD6I0qJbbvtD9OYq9+5z1EMKFluVy07vmzyW34/mcLkUcUMIZ2ur/N7BM hoiP26dG6Pen1gyuwZGZ1M8Mlj9qBGO7kPLIm7vD4w+ml473QJKoIvsFs5IAEdKjkwC+ Ec0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w19si8661609edc.371.2019.07.01.02.37.18 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Jul 2019 02:37:18 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:56466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhskP-0006Rn-TN for alex.bennee@linaro.org; Mon, 01 Jul 2019 05:37:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49721) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhseo-0002bE-Im for qemu-arm@nongnu.org; Mon, 01 Jul 2019 05:31:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhsen-0000WU-Ea for qemu-arm@nongnu.org; Mon, 01 Jul 2019 05:31:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40196) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hhsen-0000Vd-6P; Mon, 01 Jul 2019 05:31:29 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9A2143082A49; Mon, 1 Jul 2019 09:31:24 +0000 (UTC) Received: from laptop.redhat.com (ovpn-116-89.ams2.redhat.com [10.36.116.89]) by smtp.corp.redhat.com (Postfix) with ESMTP id 65C7E7DF6D; Mon, 1 Jul 2019 09:31:15 +0000 (UTC) From: Eric Auger To: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, peterx@redhat.com, pbonzini@redhat.com, alex.williamson@redhat.com Date: Mon, 1 Jul 2019 11:30:34 +0200 Message-Id: <20190701093034.18873-7-eric.auger@redhat.com> In-Reply-To: <20190701093034.18873-1-eric.auger@redhat.com> References: <20190701093034.18873-1-eric.auger@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 01 Jul 2019 09:31:28 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-arm] [PATCH v2 6/6] hw/arm/smmuv3: Remove spurious error messages on IOVA invalidations X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: 4Vjn5N5dSFYY An IOVA/ASID invalidation is notified to all IOMMU Memory Regions through smmuv3_inv_notifiers_iova/smmuv3_notify_iova. When the notification occurs it is possible that some of the PCIe devices associated to the notified regions do not have a valid stream table entry. In that case we output a LOG_GUEST_ERROR message, for example: invalid sid=3D (L1STD span=3D0) "smmuv3_notify_iova error decoding the configuration for iommu mr=3D This is unfortunate as the user gets the impression that there are some translation decoding errors whereas there are not. This patch adds a new field in SMMUEventInfo that tells whether the detection of an invalid STE must lead to an error report. invalid_ste_allowed is set before doing the invalidations and kept unset on actual translation. The other configuration decoding error messages are kept since if the STE is valid then the rest of the config must be correct. Signed-off-by: Eric Auger --- v1 -> v2: - explain why we keep the other config decoding errors - handle the new guest error log on STE invalid --- hw/arm/smmuv3-internal.h | 1 + hw/arm/smmuv3.c | 15 ++++++++------- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/arm/smmuv3-internal.h b/hw/arm/smmuv3-internal.h index b160289cd1..d190181ef1 100644 --- a/hw/arm/smmuv3-internal.h +++ b/hw/arm/smmuv3-internal.h @@ -381,6 +381,7 @@ typedef struct SMMUEventInfo { uint32_t sid; bool recorded; bool record_trans_faults; + bool inval_ste_allowed; union { struct { uint32_t ssid; diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c index 2e270a0f07..517755aed5 100644 --- a/hw/arm/smmuv3.c +++ b/hw/arm/smmuv3.c @@ -320,7 +320,9 @@ static int decode_ste(SMMUv3State *s, SMMUTransCfg *c= fg, uint32_t config; =20 if (!STE_VALID(ste)) { - qemu_log_mask(LOG_GUEST_ERROR, "invalid STE\n"); + if (!event->inval_ste_allowed) { + qemu_log_mask(LOG_GUEST_ERROR, "invalid STE\n"); + } goto bad_ste; } =20 @@ -405,7 +407,7 @@ static int smmu_find_ste(SMMUv3State *s, uint32_t sid= , STE *ste, =20 span =3D L1STD_SPAN(&l1std); =20 - if (!span) { + if (!span && !event->inval_ste_allowed) { /* l2ptr is not valid */ qemu_log_mask(LOG_GUEST_ERROR, "invalid sid=3D%d (L1STD span=3D0)\n", sid); @@ -603,7 +605,9 @@ static IOMMUTLBEntry smmuv3_translate(IOMMUMemoryRegi= on *mr, hwaddr addr, SMMUDevice *sdev =3D container_of(mr, SMMUDevice, iommu); SMMUv3State *s =3D sdev->smmu; uint32_t sid =3D smmu_get_sid(sdev); - SMMUEventInfo event =3D {.type =3D SMMU_EVT_NONE, .sid =3D sid}; + SMMUEventInfo event =3D {.type =3D SMMU_EVT_NONE, + .sid =3D sid, + .inval_ste_allowed =3D false}; SMMUPTWEventInfo ptw_info =3D {}; SMMUTranslationStatus status; SMMUState *bs =3D ARM_SMMU(s); @@ -796,16 +800,13 @@ static void smmuv3_notify_iova(IOMMUMemoryRegion *m= r, dma_addr_t iova) { SMMUDevice *sdev =3D container_of(mr, SMMUDevice, iommu); - SMMUEventInfo event =3D {}; + SMMUEventInfo event =3D {.inval_ste_allowed =3D true}; SMMUTransTableInfo *tt; SMMUTransCfg *cfg; IOMMUTLBEntry entry; =20 cfg =3D smmuv3_get_config(sdev, &event); if (!cfg) { - qemu_log_mask(LOG_GUEST_ERROR, - "%s error decoding the configuration for iommu mr=3D= %s\n", - __func__, mr->parent_obj.name); return; } =20 --=20 2.20.1