From: Laurent Pinchart Subject: Re: [PATCH 1/3] drm/bridge: ti-sn65dsi86: add link to datasheet Date: Thu, 4 Jul 2019 15:32:11 +0300 Message-ID: <20190704123211.GF6569@pendragon.ideasonboard.com> References: <20190702154419.20812-1-robdclark@gmail.com> <20190702154419.20812-2-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190702154419.20812-2-robdclark@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Rob Clark Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Sean Paul , Rob Clark , Andrzej Hajda , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Hi Rob, Thank you for the patch. On Tue, Jul 02, 2019 at 08:44:16AM -0700, Rob Clark wrote: > From: Rob Clark > > The bridge has pretty good docs, lets add a link to make them easier to > find. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index bcca9173c72a..f1a2493b86d9 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -1,6 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > * Copyright (c) 2018, The Linux Foundation. All rights reserved. > + * datasheet: http://www.ti.com/lit/ds/symlink/sn65dsi86.pdf It's in the DT bindings and it's easy to find so I'm not sure it adds lots of value to mention it here, but I don't feel very strongly about it, so if you think it can be useful I don't mind. I would however put a blank line after the copyright line in that case, and s/datasheet/Datasheet/ > */ > > #include -- Regards, Laurent Pinchart