From: Daniel Vetter Subject: Re: [PATCH v2 3/6] drm/fb-helper: Instanciate shadow FB if configured in device's mode_config Date: Wed, 10 Jul 2019 17:34:10 +0200 Message-ID: <20190710153410.GU15868@phenom.ffwll.local> References: <20190705092613.7621-1-tzimmermann@suse.de> <20190705092613.7621-4-tzimmermann@suse.de> <68f5783f-8022-3238-a6d9-c6a774b39633@tronnes.org> <59111691-5283-fb50-94a9-6960c425e81c@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 553CB6E0E4 for ; Wed, 10 Jul 2019 15:34:15 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id r12so2598796edo.5 for ; Wed, 10 Jul 2019 08:34:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <59111691-5283-fb50-94a9-6960c425e81c@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Zimmermann Cc: maxime.ripard@bootlin.com, sam@ravnborg.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, kraxel@redhat.com, airlied@redhat.com, sean@poorly.run List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBKdWwgMDcsIDIwMTkgYXQgMDY6MTQ6NTBQTSArMDIwMCwgVGhvbWFzIFppbW1lcm1h bm4gd3JvdGU6Cj4gSGkKPiAKPiBBbSAwNy4wNy4xOSB1bSAxNjozNyBzY2hyaWViIE5vcmFsZiBU csO4bm5lczoKPiA+IAo+ID4gCj4gPiBEZW4gMDUuMDcuMjAxOSAxMS4yNiwgc2tyZXYgVGhvbWFz IFppbW1lcm1hbm46Cj4gPj4gR2VuZXJpYyBmcmFtZWJ1ZmZlciBlbXVsYXRpb24gdXNlcyBhIHNo YWRvdyBidWZmZXIgZm9yIGZyYW1lYnVmZmVycyB3aXRoCj4gPj4gZGlydHkoKSBmdW5jdGlvbi4g SWYgZHJpdmVycyB3YW50IHRvIHVzZSB0aGUgc2hhZG93IEZCIHdpdGhvdXQgc3VjaCBhCj4gPj4g ZnVuY3Rpb24sIHRoZXkgY2FuIG5vdyBzZXQgcHJlZmVyX3NoYWRvdyBvciBwcmVmZXJfc2hhZG93 X2ZiZGV2IGluIHRoZWlyCj4gPj4gbW9kZV9jb25maWcgc3RydWN0dXJlcy4gVGhlIGZvcm1lciBm bGFnIGlzIGV4cG9ydGVkIHRvIHVzZXJzcGFjZSwgdGhlIGxhdHRlcgo+ID4+IGZsYWcgaXMgZmJk ZXYtb25seS4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IFRob21hcyBaaW1tZXJtYW5uIDx0emlt bWVybWFubkBzdXNlLmRlPgo+ID4+IC0tLQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hl bHBlci5jIHwgMTkgKysrKysrKysrKysrKystLS0tLQo+ID4+ICBpbmNsdWRlL2RybS9kcm1fbW9k ZV9jb25maWcuaCAgIHwgIDUgKysrKysKPiA+PiAgMiBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRp b25zKCspLCA1IGRlbGV0aW9ucygtKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9kcm1fZmJfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4g Pj4gaW5kZXggN2JhNmEwMjU1ODIxLi41NmVmMTY5ZTE4MTQgMTAwNjQ0Cj4gPj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9k cm1fZmJfaGVscGVyLmMKPiA+PiBAQCAtNDIxLDcgKzQyMSw5IEBAIHN0YXRpYyB2b2lkIGRybV9m Yl9oZWxwZXJfZGlydHlfd29yayhzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gPj4gIAkJCQly ZXR1cm47Cj4gPj4gIAkJCWRybV9mYl9oZWxwZXJfZGlydHlfYmxpdF9yZWFsKGhlbHBlciwgJmNs aXBfY29weSk7Cj4gPj4gIAkJfQo+ID4+IC0JCWhlbHBlci0+ZmItPmZ1bmNzLT5kaXJ0eShoZWxw ZXItPmZiLCBOVUxMLCAwLCAwLCAmY2xpcF9jb3B5LCAxKTsKPiA+PiArCQlpZiAoaGVscGVyLT5m Yi0+ZnVuY3MtPmRpcnR5KQo+ID4+ICsJCQloZWxwZXItPmZiLT5mdW5jcy0+ZGlydHkoaGVscGVy LT5mYiwgTlVMTCwgMCwgMCwKPiA+PiArCQkJCQkJICZjbGlwX2NvcHksIDEpOwo+ID4+ICAKPiA+ PiAgCQlpZiAoaGVscGVyLT5idWZmZXIpCj4gPj4gIAkJCWRybV9jbGllbnRfYnVmZmVyX3Z1bm1h cChoZWxwZXItPmJ1ZmZlcik7Cj4gPj4gQEAgLTYyMCw5ICs2MjIsNiBAQCBzdGF0aWMgdm9pZCBk cm1fZmJfaGVscGVyX2RpcnR5KHN0cnVjdCBmYl9pbmZvICppbmZvLCB1MzIgeCwgdTMyIHksCj4g Pj4gIAlzdHJ1Y3QgZHJtX2NsaXBfcmVjdCAqY2xpcCA9ICZoZWxwZXItPmRpcnR5X2NsaXA7Cj4g Pj4gIAl1bnNpZ25lZCBsb25nIGZsYWdzOwo+ID4+ICAKPiA+PiAtCWlmICghaGVscGVyLT5mYi0+ ZnVuY3MtPmRpcnR5KQo+ID4+IC0JCXJldHVybjsKPiA+IAo+ID4gZHJtX2ZiX2hlbHBlcl9kaXJ0 eSgpIGlzIGNhbGxlZCB1bmNvbmRpdGlvbmFsbHkgYnkKPiA+IGRybV9mYl9oZWxwZXJfc3lzX2lt YWdlYmxpdCgpIGV0IGFsLCBzbyB3ZSBuZWVkIGNoZWNrIHdpdGgKPiA+IGRybV9mYmRldl91c2Vf c2hhZG93X2ZiKCkgaGVyZS4KPiA+IAo+ID4+IC0KPiA+PiAgCXNwaW5fbG9ja19pcnFzYXZlKCZo ZWxwZXItPmRpcnR5X2xvY2ssIGZsYWdzKTsKPiA+PiAgCWNsaXAtPngxID0gbWluX3QodTMyLCBj bGlwLT54MSwgeCk7Cj4gPj4gIAljbGlwLT55MSA9IG1pbl90KHUzMiwgY2xpcC0+eTEsIHkpOwo+ ID4+IEBAIC0yMTY2LDYgKzIxNjUsMTYgQEAgc3RhdGljIHN0cnVjdCBmYl9kZWZlcnJlZF9pbyBk cm1fZmJkZXZfZGVmaW8gPSB7Cj4gPj4gIAkuZGVmZXJyZWRfaW8JPSBkcm1fZmJfaGVscGVyX2Rl ZmVycmVkX2lvLAo+ID4+ICB9Owo+ID4+ICAKPiA+PiArc3RhdGljIGJvb2wgZHJtX2ZiZGV2X3Vz ZV9zaGFkb3dfZmIoc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlcikKPiA+PiArewo+ID4+ ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGZiX2hlbHBlci0+ZGV2Owo+ID4+ICsJc3RydWN0 IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBmYl9oZWxwZXItPmZiOwo+ID4+ICsKPiA+PiArCXJldHVy biBkZXYtPm1vZGVfY29uZmlnLnByZWZlcl9zaGFkb3dfZmJkZXYgfAo+ID4+ICsJICAgICAgIGRl di0+bW9kZV9jb25maWcucHJlZmVyX3NoYWRvdyB8Cj4gPiAKPiA+IFVzZSBsb2dpY2FsIE9SIGhl cmUKPiA+IAo+ID4+ICsJICAgICAgICEhZmItPmZ1bmNzLT5kaXJ0eTsKPiA+IAo+ID4gYW5kIHlv dSBjYW4gZHJvcCB0aGUgdGhlIGRvdWJsZSBOT1QgaGVyZS4KPiA+IAo+ID4+ICt9Cj4gPj4gKwo+ ID4+ICAvKioKPiA+PiAgICogZHJtX2ZiX2hlbHBlcl9nZW5lcmljX3Byb2JlIC0gR2VuZXJpYyBm YmRldiBlbXVsYXRpb24gcHJvYmUgaGVscGVyCj4gPj4gICAqIEBmYl9oZWxwZXI6IGZiZGV2IGhl bHBlciBzdHJ1Y3R1cmUKPiA+PiBAQCAtMjIxMyw3ICsyMjIyLDcgQEAgaW50IGRybV9mYl9oZWxw ZXJfZ2VuZXJpY19wcm9iZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyLAo+ID4+ICAK PiA+PiAgCWRybV9mYl9oZWxwZXJfZmlsbF9pbmZvKGZiaSwgZmJfaGVscGVyLCBzaXplcyk7Cj4g Pj4gIAo+ID4+IC0JaWYgKGZiLT5mdW5jcy0+ZGlydHkpIHsKPiA+PiArCWlmIChkcm1fZmJkZXZf dXNlX3NoYWRvd19mYihmYl9oZWxwZXIpKSB7Cj4gPj4gIAkJc3RydWN0IGZiX29wcyAqZmJvcHM7 Cj4gPj4gIAkJdm9pZCAqc2hhZG93Owo+ID4+ICAKPiA+PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9k cm0vZHJtX21vZGVfY29uZmlnLmggYi9pbmNsdWRlL2RybS9kcm1fbW9kZV9jb25maWcuaAo+ID4+ IGluZGV4IDc1OWQ0NjJkMDI4Yi4uZTFjNzUxYWNhMzUzIDEwMDY0NAo+ID4+IC0tLSBhL2luY2x1 ZGUvZHJtL2RybV9tb2RlX2NvbmZpZy5oCj4gPj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX21vZGVf Y29uZmlnLmgKPiA+PiBAQCAtMzQ3LDYgKzM0Nyw4IEBAIHN0cnVjdCBkcm1fbW9kZV9jb25maWdf ZnVuY3Mgewo+ID4+ICAgKiBAb3V0cHV0X3BvbGxfd29yazogZGVsYXllZCB3b3JrIGZvciBwb2xs aW5nIGluIHByb2Nlc3MgY29udGV4dAo+ID4+ICAgKiBAcHJlZmVycmVkX2RlcHRoOiBwcmVmZXJy ZWQgUkJHIHBpeGVsIGRlcHRoLCB1c2VkIGJ5IGZiIGhlbHBlcnMKPiA+PiAgICogQHByZWZlcl9z aGFkb3c6IGhpbnQgdG8gdXNlcnNwYWNlIHRvIHByZWZlciBzaGFkb3ctZmIgcmVuZGVyaW5nCj4g Pj4gKyAqIEBwcmVmZXJfc2hhZG93X2ZiZGV2OiBoaW50IHRvIGZyYW1lYnVmZmVyIGVtdWxhdGlv biB0byBwcmVmZXIgc2hhZG93LWZiIFwKPiA+PiArCXJlbmRlcmluZwo+ID4gCj4gPiBJdCdzIHBy ZWZlcnJlZCB0byBoYXZlIHRoZSBkb2MgdG9nZXRoZXIgd2l0aCB0aGUgc3RydWN0IG1lbWJlci4K PiAKPiBJIGp1c3QgdHJpZWQgdG8gZm9sbG93IHRoZSBmaWxlJ3MgZXhpc3Rpbmcgc3R5bGUsIGJ1 dCBPSywgSSBkb24ndCBtaW5kLgoKSWYgaXQgYW5ub3lzIHlvdSB0b28gbXVjaCwgY29udmVydCBh bGwgdGhlIG1lbWJlciBkb2NzIGluIHRoZSBoZWFkZXIKY29tbWVudCBpbnRvIHRoZSBpbmxpbmUg c3R5bGUuIFRoYXQncyB3aGF0IEkgdXN1YWxseSBkbyB3aGVuIHRoZSBmaXJzdAppbmxpbmUga2Vy bmVsZG9jIGNvbW1lbnQgaXMgd2FycmFudGVkIChsaWtlIGhlcmUpLCBidXQgbm90IHlldCByb2xs ZWQgb3V0LgoKT3IganVzdCBtaXgmbWF0Y2ggaWYgeW91IGZlZWwgbGlrZSBub3QgZG9pbmcgdGhh dCwgd2UgaGF2ZSBsb3RzIG9mIHRoYXQKYWxyZWFkeSA6LSkKLURhbmllbAoKPiAKPiA+IGl0J3Mg bGVzcyBsaWtlbHkgdG8gYmUgZm9yZ290dGVuIHdoZW4gdGhpbmdzIGNoYW5nZS4gQW5kIHdlIGRv bid0IHVzZQo+ID4gbGluZSBjb250LiB3aGVuIHRoZSBkb2MgbGluZSBpcyB0b28gbG9uZy4gSnVz dCBjb250aW51ZSBvbiB0aGUgbmV4dCBsaW5lCj4gPiBhZnRlciBhbiBhc3Rlcml4Lgo+ID4gCj4g Pj4gICAqIEBjdXJzb3Jfd2lkdGg6IGhpbnQgdG8gdXNlcnNwYWNlIGZvciBtYXggY3Vyc29yIHdp ZHRoCj4gPj4gICAqIEBjdXJzb3JfaGVpZ2h0OiBoaW50IHRvIHVzZXJzcGFjZSBmb3IgbWF4IGN1 cnNvciBoZWlnaHQKPiA+PiAgICogQGhlbHBlcl9wcml2YXRlOiBtaWQtbGF5ZXIgcHJpdmF0ZSBk YXRhCj4gPj4gQEAgLTg1Miw2ICs4NTQsOSBAQCBzdHJ1Y3QgZHJtX21vZGVfY29uZmlnIHsKPiA+ PiAgCS8qIGR1bWIgaW9jdGwgcGFyYW1ldGVycyAqLwo+ID4+ICAJdWludDMyX3QgcHJlZmVycmVk X2RlcHRoLCBwcmVmZXJfc2hhZG93Owo+ID4+ICAKPiA+PiArCS8qIGZiZGV2IHBhcmFtZXRlcnMg Ki8KPiA+IAo+ID4gTm8gbmVlZCBmb3IgdGhpcyBjb21tZW50Lgo+ID4gCj4gPiBEb2MgY2FuIGxv b2sgbGlrZSB0aGlzLCBJJ3ZlIGRvbmUgcy9mcmFtZWJ1ZmZlci9mYmRldi86Cj4gPiAJLyoqCj4g PiAJICogQHByZWZlcl9zaGFkb3dfZmJkZXY6Cj4gPiAJICoKPiA+IAkgKiBIaW50IHRvIGZiZGV2 IGVtdWxhdGlvbiB0byBwcmVmZXIgc2hhZG93LWZiIHJlbmRlcmluZy4KPiA+IAkgKi8KPiA+IAo+ ID4+ICsJdWludDMyX3QgcHJlZmVyX3NoYWRvd19mYmRldjsKPiA+IAo+ID4gVXNlIGJvb2wgaGVy ZS4KPiA+IAo+ID4gV2l0aCB0aGF0Ogo+ID4gCj4gPiBSZXZpZXdlZC1ieTogTm9yYWxmIFRyw7hu bmVzIDxub3JhbGZAdHJvbm5lcy5vcmc+Cj4gPiAKPiA+IEkgaGF2ZSB0ZXN0ZWQgdGhpcyBvbiAy IGRyaXZlcnMgdGhhdCB1c2UgZ2VuZXJpYyBmYmRldjogdmM0IChubyBzaGFkb3cKPiA+IGJ1Zikg YW5kIG1pMDI4M3F0IHdoaWNoIGhhcyBhIGRpcnR5IGNhbGxiYWNrLgo+ID4gCj4gPiBUZXN0ZWQt Ynk6IE5vcmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgo+IAo+IFRoYW5rcyBmb3Ig cmV2aWV3aW5nIGFuZCB0ZXN0aW5nIHRoZSBwYXRjaGVzLgo+IAo+IEJlc3QgcmVnYXJkcwo+IFRo b21hcwo+IAo+ID4gCj4gPj4gKwo+ID4+ICAJLyoqCj4gPj4gIAkgKiBAcXVpcmtfYWRkZmJfcHJl ZmVyX3hiZ3JfMzBicHA6Cj4gPj4gIAkgKgo+ID4+Cj4gPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+ID4g ZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKPiA+IAo+IAo+IC0tIAo+IFRob21h cyBaaW1tZXJtYW5uCj4gR3JhcGhpY3MgRHJpdmVyIERldmVsb3Blcgo+IFNVU0UgTGludXggR21i SCwgTWF4ZmVsZHN0cmFzc2UgNSwgOTA0MDkgTnVlcm5iZXJnLCBHZXJtYW55Cj4gR0Y6IEZlbGl4 IEltZW5kw7ZyZmZlciwgTWFyeSBIaWdnaW5zLCBTcmkgUmFzaWFoCj4gSFJCIDIxMjg0IChBRyBO w7xybmJlcmcpCj4gCgoKCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50 ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVs