Received: by 2002:a5d:51d0:0:0:0:0:0 with SMTP id n16csp4016344wrv; Mon, 15 Jul 2019 04:10:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqw5TcUSbYt16Eql30TpRlz+EhoD1xa5zx+uorIkmZAjOKFOcLlQFfumqALMGYbrWN8p3Ozm X-Received: by 2002:a17:906:c78f:: with SMTP id cw15mr8382219ejb.175.1563189020520; Mon, 15 Jul 2019 04:10:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563189020; cv=none; d=google.com; s=arc-20160816; b=o3N3hqSw9ScJVbdbIC1v7lk5DFcoaR48+wtyowNH0YRZmLz9V3aVc8MOwPwmN32FXH ZczpetkcB5L/KpebFJCqsJhAT9Vs0hzcV2yj9R0lOwj8LATY7ChHOuFLU27/mZ8ASoWP OnzGMZUb04EVTK5IKsPJTMAzR0n3yTYEAaZypyPLXqKqH17wBme9ibUvVs69ibvKJzQu VvUAC5oCAloOnlxVpKS4+LkOrWSSTbAfV6zsOszW9Lsv04igjLun0pVbbfLt2LF2VNRb fBMq3xITD2PAQs1Ef8h/DFWTFuEBGnwepc2yansE4zw7N9DwQZGHNfW4J6U65kiTqh87 6y9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:to:from:date; bh=Cfa1IohNT693kOM6M68SuF5rE2rXbPzvNsUKojOH1PQ=; b=B1fpJsHqnMS20vxXtg2iD+GVbV7C5vFyZU37yihodq+5Z+o/9ICin4dbnFCrWWyQgb zRifjYaK6E94igUvEmUvcgSJqNKRAD4eXJ1v3mVhvWX79wXvnEbL9JccKW+iO4m9Fxmw 0HdpNayXyc1eWLpNgjO9Dnf2t9a6Nouy3AWNkCFxgzEm8YVLulxoxnQxk2CIh2inIvou /V8+TRVucMWtudJMOji3p54s9hZYGDj/byvRh30dh+oWfDtXInmszDa4IssBBtdcp2T6 2VoySk01W5x3xm//Zdl+5P8amGVQ4g2k67nrWUyuvbQ0Ei79vENAwdWHqgWRIEOd/QAG HkKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id rl7si9247082ejb.342.2019.07.15.04.10.20 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Jul 2019 04:10:20 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:37148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmys7-0008FD-0f for alex.bennee@linaro.org; Mon, 15 Jul 2019 07:10:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45990) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmys2-00086f-3G for qemu-arm@nongnu.org; Mon, 15 Jul 2019 07:10:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmys0-0007wP-SI for qemu-arm@nongnu.org; Mon, 15 Jul 2019 07:10:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48502) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hmys0-0007uU-KH; Mon, 15 Jul 2019 07:10:12 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7BA42309174E; Mon, 15 Jul 2019 11:10:10 +0000 (UTC) Received: from gondolin (dhcp-192-232.str.redhat.com [10.33.192.232]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D8B84F81; Mon, 15 Jul 2019 11:09:57 +0000 (UTC) Date: Mon, 15 Jul 2019 13:09:55 +0200 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Message-ID: <20190715130955.4a117388.cohuck@redhat.com> In-Reply-To: References: <20190715095545.28545-1-philmd@redhat.com> <20190715095545.28545-2-philmd@redhat.com> <6d69e8ad-d720-ce04-20f2-a03193903078@redhat.com> <20190715125653.6e65d575.cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 15 Jul 2019 11:10:10 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-arm] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Collin Walling , Sagar Karandikar , "Michael S. Tsirkin" , Palmer Dabbelt , Mark Cave-Ayland , QEMU Developers , Alistair Francis , Gerd Hoffmann , Helge Deller , Marcel Apfelbaum , David Gibson , Artyom Tarasenko , Thomas Huth , Eduardo Habkost , "open list:S390" , qemu-arm , Richard Henderson , "open list:RISC-V" , qemu-ppc , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: kA6YNoM7MCp6 On Mon, 15 Jul 2019 13:04:28 +0200 Philippe Mathieu-Daud=C3=A9 wrote: > On 7/15/19 12:56 PM, Cornelia Huck wrote: > > On Mon, 15 Jul 2019 12:48:55 +0200 > > Thomas Huth wrote: > > =20 > >> On 15/07/2019 12.19, Peter Maydell wrote: =20 > >>> On Mon, 15 Jul 2019 at 11:15, Thomas Huth wrote: = =20 > >>>> > >>>> On 15/07/2019 11.55, Philippe Mathieu-Daud=C3=A9 wrote: =20 > >>>>> If a controller device provides a PCI bus, we can plug any PCI > >>>>> daughter card on it. > >>>>> > >>>>> Signed-off-by: Philippe Mathieu-Daud=C3=A9 > >>>>> --- =20 > >>> =20 > >>>>> diff --git a/hw/pci/Kconfig b/hw/pci/Kconfig > >>>>> index 77f8b005ff..0f7267db35 100644 > >>>>> --- a/hw/pci/Kconfig > >>>>> +++ b/hw/pci/Kconfig > >>>>> @@ -1,5 +1,6 @@ > >>>>> config PCI > >>>>> bool > >>>>> + imply PCI_DEVICES =20 > >>>> > >>>> No, please don't change this. This was done on purpose, since almost= all > >>>> PCI_DEVICES do not work on s390x (so s390x does *not* imply PCI_DEVI= CES). =20 > >>> > >>> But that means that every board that provides PCI has to have an > >>> "imply PCI_DEVICES" line, which is pretty clunky just to work > >>> around an s390x limitation. > >>> > >>> Is there some way in the Kconfig syntax for s390x to say > >>> "no PCI_DEVICES" so we can have the corner-case be handled > >>> by the s390x Kconfig in one place rather than in 20 places > >>> affecting everywhere except s390x? =20 > >> > >> IIRC the problem on s390x are the legacy IRQs. s390x has only MSIs. So= I > >> guess the correct way to fix this would be to introduce some > >> PCI_LEGACY_IRQ switch and let all old devices that do not work with MSI > >> depend on it. =20 > >=20 > > s/MSI/MSI-X/, IIRC. Not sure how far 'legacy' would stretch. =20 >=20 > Maybe we can have something like PCI_LEGACY_DEVICES and PCI_MSI_DEVICES? >=20 > So if s390x only selects PCI_LEGACY (not PCI_MSI) bus, then it only get > legacy devices? Wrong way around? We need MSI-X for s390x, not plain MSI or 'legacy' (whatever that is). >=20 > Other MSI compliant should select PCI_MSI instead. PCI alone seems to > give troubles. >=20 > > cc:ing Collin in case there's something else. > > =20