From: Tom Rini Date: Wed, 17 Jul 2019 11:58:12 -0400 Subject: [U-Boot] [PATCH] menu: don't bother going interactive with just one menu item In-Reply-To: <1561090359-95211-1-git-send-email-leoyu@nvidia.com> References: <1561090359-95211-1-git-send-email-leoyu@nvidia.com> Message-ID: <20190717155812.GG5621@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Jun 21, 2019 at 12:12:39PM +0800, Leon Yu wrote: > If there is only one menu item available, prompting user to enter > choice makes little sense and just causes unnecessary boot delay. This > change makes menu_get_choice return the only one item when there is no > other choices. > > Signed-off-by: Leon Yu > Cc: Tom Warren > Cc: Stephen Warren > Cc: Thierry Reding As you note in a follow up to Frank's comment this is a behavior change that can make it harder to get into U-Boot console in some cases. Can you please expand a bit more on the case where we are using a menu and waiting the defined number of seconds is a problem (and not addressed well enough by changing the timeout, which is configurable, yes?) ? Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: