Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C93CFC76195 for ; Thu, 18 Jul 2019 01:31:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B17821849 for ; Thu, 18 Jul 2019 01:31:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="feAQqClO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728087AbfGRBbH (ORCPT ); Wed, 17 Jul 2019 21:31:07 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:49210 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727804AbfGRBbH (ORCPT ); Wed, 17 Jul 2019 21:31:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4wErmAY4zUKJSvpR2R2+UnKAN/+PII1YmLV60iUy0K0=; b=feAQqClO/uTtYlhjOXWIWpEm0W O8CbZldGibng/pHu50IoNXHDN043e9j6+jvKUsJX3m6tqz5OKF4WgJLvoHlGSpEIifEYk92Cjy5qC jkHMWjTOU9e1kolt0X8BGmYr8fcCiYHyFdbkC1qUfbeqhsFpTJXO0LtcsWg/tGUuLnK4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hnvG8-0001zA-1M; Thu, 18 Jul 2019 03:31:00 +0200 Date: Thu, 18 Jul 2019 03:31:00 +0200 From: Andrew Lunn To: Rob Herring Cc: josua@solid-run.com, netdev , stable , "David S. Miller" , Mark Rutland Subject: Re: [PATCH 1/4] dt-bindings: allow up to four clocks for orion-mdio Message-ID: <20190718013100.GB6962@lunn.ch> References: <20190706151900.14355-1-josua@solid-run.com> <20190706151900.14355-2-josua@solid-run.com> <20190709024143.GD5835@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 09, 2019 at 04:03:28PM -0600, Rob Herring wrote: > On Mon, Jul 8, 2019 at 8:41 PM Andrew Lunn wrote: > > > > > > Optional properties: > > > > - interrupts: interrupt line number for the SMI error/done interrupt > > > > -- clocks: phandle for up to three required clocks for the MDIO instance > > > > +- clocks: phandle for up to four required clocks for the MDIO instance > > > > > > This needs to enumerate exactly what the clocks are. Shouldn't there > > > be an additional clock-names value too? > > > > Hi Rob > > > > The driver does not care what they are called. It just turns them all > > on, and turns them off again when removed. > > That's fine for the driver to do, but this is the hardware description. > > It's not just what they are called, but how many too. Is 1 clock in > the DT valid? 0? It would be unusual for a given piece of h/w to > function with a variable number of clocks. Hi Rob The orion5x has 0 clocks. kirkwood, dove, Armada XP, 370 375, 380 has 1 clock. Armada 37xx has 4. So yes, 1 clock is valid. 0 clocks is also valid. The piece of hardware itself does not care how many clocks are feeding it, so long as they are all turned on. Andrew