Return-Path: Received: from verein.lst.de ([213.95.11.211]:57833 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726000AbfGRImc (ORCPT ); Thu, 18 Jul 2019 04:42:32 -0400 Date: Thu, 18 Jul 2019 10:42:30 +0200 From: Christoph Hellwig Subject: Re: [PATCH v3 3/6] dma-mapping: Remove dma_check_mask() Message-ID: <20190718084230.GB24562@lst.de> References: <20190718032858.28744-1-bauerman@linux.ibm.com> <20190718032858.28744-4-bauerman@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190718032858.28744-4-bauerman@linux.ibm.com> Sender: linux-s390-owner@vger.kernel.org List-ID: To: Thiago Jung Bauermann Cc: x86@kernel.org, iommu@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Konrad Rzeszutek Wilk , Alexey Dobriyan , Thomas Lendacky , Halil Pasic , Mike Anderson , Ram Pai On Thu, Jul 18, 2019 at 12:28:55AM -0300, Thiago Jung Bauermann wrote: > sme_active() is an x86-specific function so it's better not to call it from > generic code. Christoph Hellwig mentioned that "There is no reason why we > should have a special debug printk just for one specific reason why there > is a requirement for a large DMA mask.", so just remove dma_check_mask(). > > Signed-off-by: Thiago Jung Bauermann Looks good, Reviewed-by: Christoph Hellwig