Return-Path: Received: from verein.lst.de ([213.95.11.211]:57850 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726386AbfGRInA (ORCPT ); Thu, 18 Jul 2019 04:43:00 -0400 Date: Thu, 18 Jul 2019 10:42:58 +0200 From: Christoph Hellwig Subject: Re: [PATCH v3 4/6] x86,s390/mm: Move sme_active() and sme_me_mask to x86-specific header Message-ID: <20190718084258.GC24562@lst.de> References: <20190718032858.28744-1-bauerman@linux.ibm.com> <20190718032858.28744-5-bauerman@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190718032858.28744-5-bauerman@linux.ibm.com> Sender: linux-s390-owner@vger.kernel.org List-ID: To: Thiago Jung Bauermann Cc: x86@kernel.org, iommu@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Konrad Rzeszutek Wilk , Alexey Dobriyan , Thomas Lendacky , Halil Pasic , Mike Anderson , Ram Pai On Thu, Jul 18, 2019 at 12:28:56AM -0300, Thiago Jung Bauermann wrote: > Now that generic code doesn't reference them, move sme_active() and > sme_me_mask to x86's . > > Also remove the export for sme_active() since it's only used in files that > won't be built as modules. sme_me_mask on the other hand is used in > arch/x86/kvm/svm.c (via __sme_set() and __psp_pa()) which can be built as a > module so its export needs to stay. > > Signed-off-by: Thiago Jung Bauermann Looks good, Reviewed-by: Christoph Hellwig