Return-Path: Received: from verein.lst.de ([213.95.11.211]:57902 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726482AbfGRIo7 (ORCPT ); Thu, 18 Jul 2019 04:44:59 -0400 Date: Thu, 18 Jul 2019 10:44:56 +0200 From: Christoph Hellwig Subject: Re: [PATCH v3 6/6] s390/mm: Remove sev_active() function Message-ID: <20190718084456.GE24562@lst.de> References: <20190718032858.28744-1-bauerman@linux.ibm.com> <20190718032858.28744-7-bauerman@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190718032858.28744-7-bauerman@linux.ibm.com> Sender: linux-s390-owner@vger.kernel.org List-ID: To: Thiago Jung Bauermann Cc: x86@kernel.org, iommu@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Konrad Rzeszutek Wilk , Alexey Dobriyan , Thomas Lendacky , Halil Pasic , Mike Anderson , Ram Pai > -/* are we a protected virtualization guest? */ > -bool sev_active(void) > -{ > - return is_prot_virt_guest(); > -} > - > bool force_dma_unencrypted(struct device *dev) > { > - return sev_active(); > + return is_prot_virt_guest(); > } Do we want to keep the comment for force_dma_unencrypted? Otherwise looks good: Reviewed-by: Christoph Hellwig