Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A50CC76196 for ; Thu, 18 Jul 2019 12:44:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CAF321019 for ; Thu, 18 Jul 2019 12:44:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390276AbfGRMoP (ORCPT ); Thu, 18 Jul 2019 08:44:15 -0400 Received: from orbyte.nwl.cc ([151.80.46.58]:35396 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727794AbfGRMoO (ORCPT ); Thu, 18 Jul 2019 08:44:14 -0400 Received: from localhost ([::1]:48486 helo=tatos) by orbyte.nwl.cc with esmtp (Exim 4.91) (envelope-from ) id 1ho5ld-0005Av-Hw; Thu, 18 Jul 2019 14:44:13 +0200 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org Subject: [iptables PATCH] xtables-save: Use argv[0] as program name Date: Thu, 18 Jul 2019 14:44:09 +0200 Message-Id: <20190718124409.587-1-phil@nwl.cc> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Don't hard-code program names. This also fixes for bogus 'xtables-save' name which is no longer used. Signed-off-by: Phil Sutter --- iptables/xtables-save.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/iptables/xtables-save.c b/iptables/xtables-save.c index 98e004af4b1a4..b8d19705771ed 100644 --- a/iptables/xtables-save.c +++ b/iptables/xtables-save.c @@ -9,6 +9,7 @@ #include "config.h" #include #include +#include #include #include #include @@ -80,8 +81,8 @@ __do_output(struct nft_handle *h, const char *tablename, bool counters) time_t now = time(NULL); - printf("# Generated by xtables-save v%s on %s", - PACKAGE_VERSION, ctime(&now)); + printf("# Generated by %s v%s on %s", prog_name, + prog_vers, ctime(&now)); printf("*%s\n", tablename); /* Dump out chain names first, @@ -122,7 +123,7 @@ do_output(struct nft_handle *h, const char *tablename, bool counters) * rule */ static int -xtables_save_main(int family, const char *progname, int argc, char *argv[]) +xtables_save_main(int family, int argc, char *argv[]) { const struct builtin_table *tables; const char *tablename = NULL; @@ -133,7 +134,7 @@ xtables_save_main(int family, const char *progname, int argc, char *argv[]) FILE *file = NULL; int ret, c; - xtables_globals.program_name = progname; + xtables_globals.program_name = basename(*argv);; c = xtables_init_all(&xtables_globals, family); if (c < 0) { fprintf(stderr, "%s/%s Failed to initialize xtables\n", @@ -237,12 +238,12 @@ xtables_save_main(int family, const char *progname, int argc, char *argv[]) int xtables_ip4_save_main(int argc, char *argv[]) { - return xtables_save_main(NFPROTO_IPV4, "iptables-save", argc, argv); + return xtables_save_main(NFPROTO_IPV4, argc, argv); } int xtables_ip6_save_main(int argc, char *argv[]) { - return xtables_save_main(NFPROTO_IPV6, "ip6tables-save", argc, argv); + return xtables_save_main(NFPROTO_IPV6, argc, argv); } static int __ebt_save(struct nft_handle *h, const char *tablename, bool counters) @@ -266,8 +267,8 @@ static int __ebt_save(struct nft_handle *h, const char *tablename, bool counters if (first) { now = time(NULL); - printf("# Generated by ebtables-save v%s on %s", - PACKAGE_VERSION, ctime(&now)); + printf("# Generated by %s v%s on %s", prog_name, + prog_vers, ctime(&now)); first = false; } printf("*%s\n", tablename); @@ -307,7 +308,7 @@ int xtables_eb_save_main(int argc_, char *argv_[]) } } - xtables_globals.program_name = "ebtables-save"; + xtables_globals.program_name = basename(*argv_); c = xtables_init_all(&xtables_globals, h.family); if (c < 0) { fprintf(stderr, "%s/%s Failed to initialize xtables\n", @@ -361,7 +362,7 @@ int xtables_arp_save_main(int argc, char **argv) }; int c; - xtables_globals.program_name = "arptables-save"; + xtables_globals.program_name = basename(*argv);; c = xtables_init_all(&xtables_globals, h.family); if (c < 0) { fprintf(stderr, "%s/%s Failed to initialize xtables\n", -- 2.22.0