Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89472C76195 for ; Thu, 18 Jul 2019 15:13:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6967720873 for ; Thu, 18 Jul 2019 15:13:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728008AbfGRPNP (ORCPT ); Thu, 18 Jul 2019 11:13:15 -0400 Received: from orbyte.nwl.cc ([151.80.46.58]:35672 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727976AbfGRPNO (ORCPT ); Thu, 18 Jul 2019 11:13:14 -0400 Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.91) (envelope-from ) id 1ho85p-00041U-01; Thu, 18 Jul 2019 17:13:13 +0200 Date: Thu, 18 Jul 2019 17:13:12 +0200 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org Subject: Re: [iptables PATCH] xtables-save: Use argv[0] as program name Message-ID: <20190718151312.GJ1628@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org References: <20190718124409.587-1-phil@nwl.cc> <20190718150516.cdnun6v3ssr6lh2d@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190718150516.cdnun6v3ssr6lh2d@salvia> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hi, On Thu, Jul 18, 2019 at 05:05:16PM +0200, Pablo Neira Ayuso wrote: > On Thu, Jul 18, 2019 at 02:44:09PM +0200, Phil Sutter wrote: > > Don't hard-code program names. This also fixes for bogus 'xtables-save' > > name which is no longer used. > > Applied, thanks Phil. > > BTW, it seems arptables-save doesn't print: > > # Generated by ... Also, ip{,6}tables-save prints that line once per table while ebtables-save does it once for all. And theres: | # Completed on ... which neither arp- nor ebtables-save print. > for some reason, probably good to get this consistent with other > existing -save tools. We can assume lines starting with '#' are ignored by any potential parser of any family's dump files, right? Cheers, Phil