From: Wolfgang Denk Date: Fri, 19 Jul 2019 10:45:40 +0200 Subject: [U-Boot] [RFC, PATCH v4 10/16] env: save non-volatile variables only In-Reply-To: <20190717082525.891-11-takahiro.akashi@linaro.org> References: <20190717082525.891-1-takahiro.akashi@linaro.org> <20190717082525.891-11-takahiro.akashi@linaro.org> Message-ID: <20190719084540.33A72240049@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de Dear AKASHI Takahiro, In message <20190717082525.891-11-takahiro.akashi@linaro.org> you wrote: > Once variable storage attribute is introduced, only NON_VOLATILE or > NON_VOLATILE_AUTOSAVE variables should be saved to backing storage. This logis is wrong. It should read: Variables which have the "volatile" flag set will be skipped when savong the environment. > In addition, NON_VOLATILE_AUTOSAVE variables are saved immediately > at env_set[_ext](). This is completely independent, and should eventually even be a separate commit: Variables which have the 'autosave" flag set are saved with each (successful) env_set(). Yes, I made up my mind: Adding "volatile" and "autosave" is two independent features, this should be relfected in two separate commits / patch series. Probably even independent from and preceeding the context series. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Es ist nicht genug zu wissen, man muß auch anwenden; es ist nicht ge- nug zu wollen, man muß auch tun. -- Goethe, Maximen und Reflexionen