Received: from list by lists.gnu.org with archive (Exim 4.86_2) id 1hoSiz-00005B-1a for mharc-qemu-trivial@gnu.org; Fri, 19 Jul 2019 09:15:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60732) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoSiv-0008Ga-Om for qemu-trivial@nongnu.org; Fri, 19 Jul 2019 09:14:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hoSiu-0000YF-Ny for qemu-trivial@nongnu.org; Fri, 19 Jul 2019 09:14:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33526) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hoSio-0000T3-H7; Fri, 19 Jul 2019 09:14:50 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BA87F2ED2E0; Fri, 19 Jul 2019 13:14:49 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.153]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EB69426E5A; Fri, 19 Jul 2019 13:14:43 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , qemu-block@nongnu.org, Michael Tokarev , qemu-trivial@nongnu.org, Corey Minyard , Max Reitz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Peter Maydell , Kevin Wolf , qemu-ppc@nongnu.org, Paolo Bonzini , Stefan Weil Date: Fri, 19 Jul 2019 15:14:20 +0200 Message-Id: <20190719131425.10835-3-philmd@redhat.com> In-Reply-To: <20190719131425.10835-1-philmd@redhat.com> References: <20190719131425.10835-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 19 Jul 2019 13:14:49 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-trivial] [PATCH-for-4.1? 2/7] hw/dma/omap_dma: Move switch 'fall through' comment to correct place X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jul 2019 13:15:00 -0000 Reported by GCC9 when building with CFLAG -Wimplicit-fallthrough=3D2: CC hw/dma/omap_dma.o hw/dma/omap_dma.c: In function =E2=80=98omap_dma_write=E2=80=99: hw/dma/omap_dma.c:1532:12: error: this statement may fall through [-Wer= ror=3Dimplicit-fallthrough=3D] 1532 | if (s->model <=3D omap_dma_3_1) | ^ hw/dma/omap_dma.c:1534:5: note: here 1534 | case 0x400: | ^~~~ cc1: all warnings being treated as errors Correctly place the 'fall through' comment. Reported-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/dma/omap_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/dma/omap_dma.c b/hw/dma/omap_dma.c index eab83c5c3a..6677237d42 100644 --- a/hw/dma/omap_dma.c +++ b/hw/dma/omap_dma.c @@ -1531,8 +1531,8 @@ static void omap_dma_write(void *opaque, hwaddr add= r, case 0x404 ... 0x4fe: if (s->model <=3D omap_dma_3_1) break; + /* fall through */ case 0x400: - /* Fall through. */ if (omap_dma_sys_write(s, addr, value)) break; return; --=20 2.20.1