Received: from list by lists.gnu.org with archive (Exim 4.86_2) id 1hoSj8-0000gl-Dq for mharc-qemu-trivial@gnu.org; Fri, 19 Jul 2019 09:15:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60838) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoSj4-0000PO-0h for qemu-trivial@nongnu.org; Fri, 19 Jul 2019 09:15:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hoSj2-0000g3-Uw for qemu-trivial@nongnu.org; Fri, 19 Jul 2019 09:15:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60250) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hoSiw-0000Z6-DU; Fri, 19 Jul 2019 09:14:58 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9E83030BD1BF; Fri, 19 Jul 2019 13:14:57 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.153]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4E6602657C; Fri, 19 Jul 2019 13:14:50 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , qemu-block@nongnu.org, Michael Tokarev , qemu-trivial@nongnu.org, Corey Minyard , Max Reitz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Peter Maydell , Kevin Wolf , qemu-ppc@nongnu.org, Paolo Bonzini , Stefan Weil Date: Fri, 19 Jul 2019 15:14:21 +0200 Message-Id: <20190719131425.10835-4-philmd@redhat.com> In-Reply-To: <20190719131425.10835-1-philmd@redhat.com> References: <20190719131425.10835-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 19 Jul 2019 13:14:57 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-trivial] [PATCH-for-4.1 3/7] hw/block/pflash_cfi02: Rewrite a fall through comment X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jul 2019 13:15:08 -0000 GCC9 is confused by this comment when building with CFLAG -Wimplicit-fallthrough=3D2: hw/block/pflash_cfi02.c: In function =E2=80=98pflash_write=E2=80=99: hw/block/pflash_cfi02.c:574:16: error: this statement may fall through = [-Werror=3Dimplicit-fallthrough=3D] 574 | if (boff =3D=3D 0x55 && cmd =3D=3D 0x98) { | ^ hw/block/pflash_cfi02.c:581:9: note: here 581 | default: | ^~~~~~~ cc1: all warnings being treated as errors Rewrite the comment using 'fall through' which is recognized by GCC and static analyzers. Reported-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/block/pflash_cfi02.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c index f68837a449..42886f6af5 100644 --- a/hw/block/pflash_cfi02.c +++ b/hw/block/pflash_cfi02.c @@ -577,7 +577,7 @@ static void pflash_write(void *opaque, hwaddr offset,= uint64_t value, pfl->cmd =3D 0x98; return; } - /* No break here */ + /* fall through */ default: DPRINTF("%s: invalid write for command %02x\n", __func__, pfl->cmd); --=20 2.20.1