Received: from list by lists.gnu.org with archive (Exim 4.86_2) id 1hoSjE-000156-Kz for mharc-qemu-trivial@gnu.org; Fri, 19 Jul 2019 09:15:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60887) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoSj9-0000lE-F9 for qemu-trivial@nongnu.org; Fri, 19 Jul 2019 09:15:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hoSj8-0000nt-Gs for qemu-trivial@nongnu.org; Fri, 19 Jul 2019 09:15:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29825) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hoSj2-0000fC-8f; Fri, 19 Jul 2019 09:15:04 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 65891308620E; Fri, 19 Jul 2019 13:15:03 +0000 (UTC) Received: from x1w.redhat.com (unknown [10.40.205.153]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6B0462657C; Fri, 19 Jul 2019 13:14:58 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , qemu-block@nongnu.org, Michael Tokarev , qemu-trivial@nongnu.org, Corey Minyard , Max Reitz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier , Peter Maydell , Kevin Wolf , qemu-ppc@nongnu.org, Paolo Bonzini , Stefan Weil Date: Fri, 19 Jul 2019 15:14:22 +0200 Message-Id: <20190719131425.10835-5-philmd@redhat.com> In-Reply-To: <20190719131425.10835-1-philmd@redhat.com> References: <20190719131425.10835-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 19 Jul 2019 13:15:03 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-trivial] [PATCH-for-4.1? 4/7] hw/ipmi: Rewrite a fall through comment X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jul 2019 13:15:15 -0000 GCC9 is confused by this comment when building with CFLAG -Wimplicit-fallthrough=3D2: hw/ipmi/ipmi_bmc_extern.c: In function =E2=80=98addchar=E2=80=99: hw/ipmi/ipmi_bmc_extern.c:178:12: error: this statement may fall throug= h [-Werror=3Dimplicit-fallthrough=3D] 178 | ch |=3D 0x10; | ~~~^~~~~~~ hw/ipmi/ipmi_bmc_extern.c:181:5: note: here 181 | default: | ^~~~~~~ cc1: all warnings being treated as errors make: *** [rules.mak:69: hw/ipmi/ipmi_bmc_extern.o] Error 1 Rewrite the comment using 'fall through' which is recognized by GCC and static analyzers. Reported-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/ipmi/ipmi_bmc_extern.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c index c0a8dac346..d4cbd210c4 100644 --- a/hw/ipmi/ipmi_bmc_extern.c +++ b/hw/ipmi/ipmi_bmc_extern.c @@ -176,8 +176,7 @@ static void addchar(IPMIBmcExtern *ibe, unsigned char= ch) ibe->outbuf[ibe->outlen] =3D VM_ESCAPE_CHAR; ibe->outlen++; ch |=3D 0x10; - /* No break */ - + /* fall through */ default: ibe->outbuf[ibe->outlen] =3D ch; ibe->outlen++; --=20 2.20.1