Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36BAAC7618F for ; Fri, 19 Jul 2019 19:07:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 105242085A for ; Fri, 19 Jul 2019 19:07:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="RV1ZYT6H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732535AbfGSTHS (ORCPT ); Fri, 19 Jul 2019 15:07:18 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:52756 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730005AbfGSTHR (ORCPT ); Fri, 19 Jul 2019 15:07:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=j7IZrZH3GJiBDd3CXEJSZAWNWsGiZLu9qMPgzBxZysQ=; b=RV1ZYT6HnWmOwtdgeuTBwVibgU pH/XPVF9qYWg2UtRo0wa7eX5ENbKOclnpejWmw30sX2T3FDvCtlw6qyQnKiFVNhy9eTpWTm9TAcYU yeKtXT0QsL6Pvby5+G1Gq/3KVvBzMjK41LIGTxMaGu3mr9fwyVQy5/18DdFDPO//90Yk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hoYDr-0008SH-HN; Fri, 19 Jul 2019 21:07:15 +0200 Date: Fri, 19 Jul 2019 21:07:15 +0200 From: Andrew Lunn To: Shannon Nelson Cc: netdev@vger.kernel.org Subject: Re: [PATCH v3 net-next 13/19] ionic: Add initial ethtool support Message-ID: <20190719190715.GO25635@lunn.ch> References: <20190708192532.27420-1-snelson@pensando.io> <20190708192532.27420-14-snelson@pensando.io> <20190709021426.GA5835@lunn.ch> <10c66ecf-6d67-d206-b496-6f8139f218a8@pensando.io> <20190718032814.GH6962@lunn.ch> <00a22345-4904-57b4-f40b-9ddd2e7398ec@pensando.io> <20190719024013.GC24765@lunn.ch> <15796ade-68dd-4350-e481-3a3a1e7ce3d5@pensando.io> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <15796ade-68dd-4350-e481-3a3a1e7ce3d5@pensando.io> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jul 19, 2019 at 11:41:28AM -0700, Shannon Nelson wrote: > On 7/18/19 7:40 PM, Andrew Lunn wrote: > >On Thu, Jul 18, 2019 at 05:12:07PM -0700, Shannon Nelson wrote: > >>On 7/17/19 8:28 PM, Andrew Lunn wrote: > >>>On Fri, Jul 12, 2019 at 10:16:31PM -0700, Shannon Nelson wrote: > >>>>On 7/8/19 7:14 PM, Andrew Lunn wrote: > >>>>>>+static int ionic_set_pauseparam(struct net_device *netdev, > >>>>>>+ struct ethtool_pauseparam *pause) > >>>>>>+{ > >>>>>>+ struct lif *lif = netdev_priv(netdev); > >>>>>>+ struct ionic *ionic = lif->ionic; > >>>>>>+ struct ionic_dev *idev = &lif->ionic->idev; > >>>>>>+ > >>>>>>+ u32 requested_pause; > >>>>>>+ u32 cur_autoneg; > >>>>>>+ int err; > >>>>>>+ > >>>>>>+ cur_autoneg = idev->port_info->config.an_enable ? AUTONEG_ENABLE : > >>>>>>+ AUTONEG_DISABLE; > >>>>>>+ if (pause->autoneg != cur_autoneg) { > >>>>>>+ netdev_info(netdev, "Please use 'ethtool -s ...' to change autoneg\n"); > >>>>>>+ return -EOPNOTSUPP; > >>>>>>+ } > >>>>>>+ > >>>>>>+ /* change both at the same time */ > >>>>>>+ requested_pause = PORT_PAUSE_TYPE_LINK; > >>>>>>+ if (pause->rx_pause) > >>>>>>+ requested_pause |= IONIC_PAUSE_F_RX; > >>>>>>+ if (pause->tx_pause) > >>>>>>+ requested_pause |= IONIC_PAUSE_F_TX; > >>>>>>+ > >>>>>>+ if (requested_pause == idev->port_info->config.pause_type) > >>>>>>+ return 0; > >>>>>>+ > >>>>>>+ idev->port_info->config.pause_type = requested_pause; > >>>>>>+ > >>>>>>+ mutex_lock(&ionic->dev_cmd_lock); > >>>>>>+ ionic_dev_cmd_port_pause(idev, requested_pause); > >>>>>>+ err = ionic_dev_cmd_wait(ionic, devcmd_timeout); > >>>>>>+ mutex_unlock(&ionic->dev_cmd_lock); > >>>>>>+ if (err) > >>>>>>+ return err; > >>>>>Hi Shannon > >>>>> > >>>>>I've no idea what the firmware black box is doing, but this looks > >>>>>wrong. > >>>>> > >>>>>pause->autoneg is about if the results of auto-neg should be used or > >>>>>not. If false, just configure the MAC with the pause settings and you > >>>>>are done. If the interface is being forced, so autoneg in general is > >>>>>disabled, just configure the MAC and you are done. > >>>>> > >>>>>If pause->autoneg is true and the interface is using auto-neg as a > >>>>>whole, you pass the pause values to the PHY for it to advertise and > >>>>>trigger an auto-neg. Once autoneg has completed, and the resolved > >>>>>settings are available, the MAC is configured with the resolved > >>>>>values. > >>>>> > >>>>>Looking at this code, i don't see any difference between configuring > >>>>>the MAC or configuring the PHY. I would expect pause->autoneg to be > >>>>>part of requested_pause somehow, so the firmware knows what is should > >>>>>do. > >>>>> > >>>>> Andrew > >>>>In this device there's actually very little the driver can do to directly > >>>>configure the mac or phy besides passing through to the firmware what the > >>>>user has requested - that happens here for the pause values, and in > >>>>ionic_set_link_ksettings() for autoneg.  The firmware is managing the port > >>>>based on these requests with the help of internally configured rules defined > >>>>in a customer setting. > >>>I get that. But the firmware needs to conform to what Linux > >>>expects. And what i see here does not conform. That is why i gave a > >>>bit of detail in my reply. > >>> > >>>What exactly does the firmware do? Once we know that, we can figure > >>>out when the driver should return -EOPNOTSUPP because of firmware > >>>limitations, and what it can configure and should return 0. > >>Because this is fairly smart FW, it handles this as expected.  I can add > >>this as another comment in the code. > >Hi Shannon > > > >Looking at the code, i don't see how it can handle this > >correctly. Please look at my comments, particularly the meaning of > >pause->autoneg and describe how the firmware does the right thing, > >given what information it is passed. > > > > I guess I'm not sure how much better I can answer your question. Like > several other devices, we don't support selecting pause->autoneg.  The > firmware manages the PHY itself, the driver doesn't have direct access to > the PHY.  The driver passes the tx and rx pause info down to the firmware in > a command request.  The NIC firmware does an autoneg if autoneg is enabled > on the port. Hi Shannon Thanks. That was the information i was looking for. Please return -EOPNOTSUPP if pause->autoneg indicates autoneg results should not be used. Your firmware does not support it, so the driver should error out. Also the get function should use a hard coded value for pause->autoneg. If you ever fix your firmware, you can add full support for pause configuration. Thanks Andrew