From: Wolfgang Denk Date: Wed, 24 Jul 2019 08:51:06 +0200 Subject: [U-Boot] [PATCH 2/4] armv8: ls2088aqds: The ls2088aqds board supports the I2C driver model. In-Reply-To: <20190724025904.469-2-chuanhua.han@nxp.com> References: <20190724025904.469-1-chuanhua.han@nxp.com> <20190724025904.469-2-chuanhua.han@nxp.com> Message-ID: <20190724065106.E054924005E@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Chuanhua Han, In message <20190724025904.469-2-chuanhua.han@nxp.com> you wrote: ... > /* Set I2c to Slot 1 */ > +#ifndef CONFIG_DM_I2C > i2c_write(0x77, 0, 0, &a, 1); > +#else > + struct udevice *udev; Please - no declarations in the in the middle of the code (even if #ifdef'ed). Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Wherever you go...There you are. - Buckaroo Banzai