From: Christoph Hellwig Date: Wed, 24 Jul 2019 03:00:30 -0700 Subject: [Cluster-devel] [PATCH] fs: gfs2: Fix a null-pointer dereference in gfs2_alloc_inode() In-Reply-To: <20190724084303.1236-1-baijiaju1990@gmail.com> References: <20190724084303.1236-1-baijiaju1990@gmail.com> Message-ID: <20190724100030.GA2239@infradead.org> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Jul 24, 2019 at 04:43:03PM +0800, Jia-Ju Bai wrote: > index 0acc5834f653..c07c3f4f8451 100644 > --- a/fs/gfs2/super.c > +++ b/fs/gfs2/super.c > @@ -1728,8 +1728,9 @@ static struct inode *gfs2_alloc_inode(struct super_block *sb) > memset(&ip->i_res, 0, sizeof(ip->i_res)); > RB_CLEAR_NODE(&ip->i_res.rs_node); > ip->i_rahead = 0; > - } > - return &ip->i_inode; > + return &ip->i_inode; > + } else > + return NULL; > } No need for an else after a return. You probably just want to return early for the NULL case.