From: "Theodore Y. Ts'o" Date: Sun, 28 Jul 2019 21:24:31 +0000 Subject: Re: [PATCH v7 13/16] ext4: wire up new fscrypt ioctls Message-Id: <20190728212431.GN6088@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <20190726224141.14044-1-ebiggers@kernel.org> <20190726224141.14044-14-ebiggers@kernel.org> In-Reply-To: <20190726224141.14044-14-ebiggers@kernel.org> To: Eric Biggers Cc: Satya Tangirala , linux-api@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, keyrings@vger.kernel.org, linux-mtd@lists.infradead.org, linux-crypto@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Paul Crowley On Fri, Jul 26, 2019 at 03:41:38PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Wire up the new ioctls for adding and removing fscrypt keys to/from the > filesystem, and the new ioctl for retrieving v2 encryption policies. > > FS_IOC_REMOVE_ENCRYPTION_KEY also required making ext4_drop_inode() call > fscrypt_drop_inode(). > > For more details see Documentation/filesystems/fscrypt.rst and the > fscrypt patches that added the implementation of these ioctls. > > Signed-off-by: Eric Biggers Looks good, feel free to add: Reviewed-by: Theodore Ts'o - Ted