From: Bjorn Helgaas Date: Tue, 30 Jul 2019 18:25:03 +0000 Subject: Re: [PATCH v2 0/5] PCI: Convert pci_resource_to_user() to a weak function Message-Id: <20190730182503.GJ203187@google.com> List-Id: References: <20190729101401.28068-1-efremov@linux.com> In-Reply-To: <20190729101401.28068-1-efremov@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Denis Efremov Cc: "David S. Miller" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Ralf Baechle , Paul Burton , James Hogan , Michal Simek , linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, Jul 29, 2019 at 01:13:56PM +0300, Denis Efremov wrote: > Architectures currently define HAVE_ARCH_PCI_RESOURCE_TO_USER if they want > to provide their own pci_resource_to_user() implementation. This could be > simplified if we make the generic version a weak function. Thus, > architecture specific versions will automatically override the generic one. > > Changes in v2: > 1. Removed __weak from pci_resource_to_user() declaration > 2. Fixed typo s/spark/sparc/g > > Denis Efremov (5): > PCI: Convert pci_resource_to_user to a weak function > microblaze/PCI: Remove HAVE_ARCH_PCI_RESOURCE_TO_USER > mips/PCI: Remove HAVE_ARCH_PCI_RESOURCE_TO_USER > powerpc/PCI: Remove HAVE_ARCH_PCI_RESOURCE_TO_USER > sparc/PCI: Remove HAVE_ARCH_PCI_RESOURCE_TO_USER > > arch/microblaze/include/asm/pci.h | 2 -- > arch/mips/include/asm/pci.h | 1 - > arch/powerpc/include/asm/pci.h | 2 -- > arch/sparc/include/asm/pci.h | 2 -- > drivers/pci/pci.c | 8 ++++++++ > include/linux/pci.h | 12 ------------ > 6 files changed, 8 insertions(+), 19 deletions(-) Thanks, I added Paul's ack, squashed into a single patch since I think it's easier to see what's going on then, and applied to pci/misc for v4.5.