From: Greg Kurz Date: Thu, 01 Aug 2019 09:23:48 +0000 Subject: Re: [PATCH 1/2] powerpc/xive: Use GFP_KERNEL instead of GFP_ATOMIC in 'xive_irq_bitmap_add()' Message-Id: <20190801112348.2d1760f3@bahia.lan> List-Id: References: <85d5d247ce753befd6aa63c473f7823de6520ccd.1564647619.git.christophe.jaillet@wanadoo.fr> In-Reply-To: <85d5d247ce753befd6aa63c473f7823de6520ccd.1564647619.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, paulus@samba.org, clg@kaod.org, tglx@linutronix.de, linuxppc-dev@lists.ozlabs.org, allison@lohutok.net On Thu, 1 Aug 2019 10:32:31 +0200 Christophe JAILLET wrote: > There is no need to use GFP_ATOMIC here. GFP_KERNEL should be enough. > GFP_KERNEL is also already used for another allocation just a few lines > below. > > Signed-off-by: Christophe JAILLET > --- Good catch. Reviewed-by: Greg Kurz > arch/powerpc/sysdev/xive/spapr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/sysdev/xive/spapr.c b/arch/powerpc/sysdev/xive/spapr.c > index 8ef9cf4ebb1c..b4f5eb9e0f82 100644 > --- a/arch/powerpc/sysdev/xive/spapr.c > +++ b/arch/powerpc/sysdev/xive/spapr.c > @@ -45,7 +45,7 @@ static int xive_irq_bitmap_add(int base, int count) > { > struct xive_irq_bitmap *xibm; > > - xibm = kzalloc(sizeof(*xibm), GFP_ATOMIC); > + xibm = kzalloc(sizeof(*xibm), GFP_KERNEL); > if (!xibm) > return -ENOMEM; >