Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05FF4C433FF for ; Mon, 5 Aug 2019 10:35:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1FAE20856 for ; Mon, 5 Aug 2019 10:35:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728028AbfHEKfS (ORCPT ); Mon, 5 Aug 2019 06:35:18 -0400 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:41522 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727230AbfHEKfS (ORCPT ); Mon, 5 Aug 2019 06:35:18 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.89) (envelope-from ) id 1huaKi-0001gO-QV; Mon, 05 Aug 2019 12:35:16 +0200 Date: Mon, 5 Aug 2019 12:35:16 +0200 From: Florian Westphal To: Michael Braun Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH] netfilter: nfnetlink_log:add support for VLAN information Message-ID: <20190805103516.ctrrelq3zcorhr3n@breakpoint.cc> References: <20190805072814.14922-1-michael-dev@fami-braun.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190805072814.14922-1-michael-dev@fami-braun.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Michael Braun wrote: > Currently, there is no vlan information (e.g. when used with a vlan aware > bridge) passed to userspache, HWHEADER will contain an 08 00 (ip) suffix > even for tagged ip packets. > > Therefore, add an extra netlink attribute that passes the vlan tag to > userspace. Userspace might need to handle PCP/DEI included in this field. > > Signed-off-by: Michael Braun nfqueue has nfqnl_put_bridge() helper which will plcae both tci and proto in a nested attribute, I wonder if we can just re-use that? (Yes, we need new attributes unfortunately).