Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D6C4C31E40 for ; Tue, 6 Aug 2019 06:43:54 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4638D2147A for ; Tue, 6 Aug 2019 06:43:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4638D2147A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id EF646CAD; Tue, 6 Aug 2019 06:43:53 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id A7F03CAC for ; Tue, 6 Aug 2019 06:43:52 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 34B95829 for ; Tue, 6 Aug 2019 06:43:52 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id DAA6F68B02; Tue, 6 Aug 2019 08:43:47 +0200 (CEST) Date: Tue, 6 Aug 2019 08:43:47 +0200 From: Christoph Hellwig To: Lu Baolu Subject: Re: [PATCH 2/3] iommu/vt-d: Apply per-device dma_ops Message-ID: <20190806064347.GA14906@lst.de> References: <20190801060156.8564-1-baolu.lu@linux.intel.com> <20190801060156.8564-3-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190801060156.8564-3-baolu.lu@linux.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: kevin.tian@intel.com, ashok.raj@intel.com, Robin Murphy , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, jacob.jun.pan@intel.com, David Woodhouse , Christoph Hellwig X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org Hi Lu, I really do like the switch to the per-device dma_map_ops, but: On Thu, Aug 01, 2019 at 02:01:55PM +0800, Lu Baolu wrote: > Current Intel IOMMU driver sets the system level dma_ops. This > implementation has at least the following drawbacks: 1) each > dma API will go through the IOMMU driver even the devices are > using identity mapped domains; 2) if user requests to use an > identity mapped domain (a.k.a. bypass iommu translation), the > driver might fall back to dma domain blindly if the device is > not able to address all system memory. This is very clearly a behavioral regression. The intel-iommu driver has always used the iommu mapping to provide decent support for devices that do not have the full 64-bit addressing capability, and changing this will make a lot of existing setups go slower. I don't think having to use swiotlb for these devices helps anyone. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu