From: Christoph Hellwig Subject: Re: [PATCH 3/4] csky/dma: Fixup cache_op failed when cross memory ZONEs Date: Tue, 6 Aug 2019 00:18:46 -0700 Message-ID: <20190806071846.GA10032@infradead.org> References: <1564488945-20149-1-git-send-email-guoren@kernel.org> <1564488945-20149-3-git-send-email-guoren@kernel.org> <20190806064933.GA2508@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Guo Ren Cc: Christoph Hellwig , Arnd Bergmann , Linux Kernel Mailing List , linux-arch , linux-csky@vger.kernel.org, feng_shizhu@dahuatech.com, zhang_jian5@dahuatech.com, zheng_xingjian@dahuatech.com, zhu_peng@dahuatech.com, Guo Ren List-Id: linux-arch.vger.kernel.org On Tue, Aug 06, 2019 at 03:11:13PM +0800, Guo Ren wrote: > On Tue, Aug 6, 2019 at 2:49 PM Christoph Hellwig wrote: > > > > On Tue, Jul 30, 2019 at 08:15:44PM +0800, guoren@kernel.org wrote: > > > diff --git a/arch/csky/mm/dma-mapping.c b/arch/csky/mm/dma-mapping.c > > > index 80783bb..3f1ff9d 100644 > > > --- a/arch/csky/mm/dma-mapping.c > > > +++ b/arch/csky/mm/dma-mapping.c > > > @@ -18,71 +18,52 @@ static int __init atomic_pool_init(void) > > > { > > > return dma_atomic_pool_init(GFP_KERNEL, pgprot_noncached(PAGE_KERNEL)); > > > } > > > -postcore_initcall(atomic_pool_init); > > > > Please keep the postcore_initcall next to the function it calls. > Ok. Change arch_initcall back to postcore_initcall. :) Well, if you have a good reason to change it please keep the type init level change, but put it in a separate patch. But most importantly don't move the place where is called around.