From: Thomas Petazzoni Date: Tue, 13 Aug 2019 16:19:44 +0200 Subject: [Buildroot] [PATCH v3 1/3] autobuild-run: maintain consistency in diffoscope command In-Reply-To: <20190813041206.20715-1-itsatharva@gmail.com> References: <20190813041206.20715-1-itsatharva@gmail.com> Message-ID: <20190813161944.1610eb65@windsurf.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Atharva, On Tue, 13 Aug 2019 09:42:04 +0530 Atharva Lele wrote: > Since we are outputting to two file types, we can't just redirect stdout. > Instead, we use diffoscope's ability to output to a file to maintain > consistency in the command. > > This patch also fixes a typo in the command. For text output, > it should be reproducibility_results_txt instead of > reproducibility_results_text. > > Signed-off-by: Atharva Lele > --- > scripts/autobuild-run | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied to buildroot-test, thanks. However, the code running diffoscope is still executed inside a with open(reproducible_results, 'w') as diff, which is no longer needed, as diffoscope outputs directly to the reproducible_results file. You should move that this file opening inside the else condition which is used when diffoscope is not available. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com