From: Thomas Petazzoni Date: Fri, 16 Aug 2019 14:31:42 +0200 Subject: [Buildroot] [PATCH 1/1] package/gstreamer1/gst1-plugins-bad: fix opengl dependency In-Reply-To: References: <20190807215804.100437-1-james.hilliard1@gmail.com> <20190816000232.6c7f88b8@windsurf.home> Message-ID: <20190816143142.3653b7ea@windsurf.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello James, +Peter Seiderer On Thu, 15 Aug 2019 16:54:56 -0600 James Hilliard wrote: > On Thu, Aug 15, 2019 at 4:02 PM Thomas Petazzoni > wrote: > > > > James, Adrian, Adam, > > > > On Wed, 7 Aug 2019 15:58:04 -0600 > > James Hilliard wrote: > > > > > Fixes: > > > WPEThreadedView.h:24:10: fatal error: gst/gl/gl.h: No such file or directory > > > #include So, I just did a test with the following defconfig, which only has OpenGL ES (provided by rpi-userland) and not the full OpenGL: BR2_arm=y BR2_TOOLCHAIN_EXTERNAL=y BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2019.05.1.tar.bz2" BR2_TOOLCHAIN_EXTERNAL_GCC_4_9=y BR2_TOOLCHAIN_EXTERNAL_HEADERS_4_14=y BR2_TOOLCHAIN_EXTERNAL_LOCALE=y # BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set BR2_TOOLCHAIN_EXTERNAL_CXX=y BR2_INIT_NONE=y BR2_SYSTEM_BIN_SH_NONE=y # BR2_PACKAGE_BUSYBOX is not set BR2_PACKAGE_GSTREAMER1=y BR2_PACKAGE_GST1_PLUGINS_BASE=y # BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOCONVERT is not set # BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORESAMPLE is not set # BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME is not set BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL=y BR2_PACKAGE_RPI_USERLAND=y # BR2_TARGET_ROOTFS_TAR is not set And it does provide gst/gl/gl.h: $ find . -name 'gl.h' ./output/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/GLES/gl.h So, gst/gl/gl.h is provided when OpenGL ES is used, which means your patch is most likely incorrect, and we should allow enabling the wpe plugin when OpenGL ES is available. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com