From: Ayan Halder Subject: [PATCH] drm/komeda: Reordered the komeda's de-init functions Date: Tue, 20 Aug 2019 17:46:19 +0000 Message-ID: <20190820174606.1133-1-ayan.halder@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Ayan Halder , Liviu Dudau , Brian Starkey , "malidp@foss.arm.com" , "james qian wang (Arm Technology China)" , "airlied@linux.ie" , "daniel@ffwll.ch" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Cc: nd List-Id: dri-devel@lists.freedesktop.org The de-init routine should be doing the following in order:- 1. Unregister the drm device 2. Shut down the crtcs - failing to do this might cause a connector leakage See the 'commit 109c4d18e574 ("drm/arm/malidp: Ensure that the crtcs are shutdown before removing any encoder/connector")' 3. Disable the interrupts 4. Unbind the components 5. Free up DRM mode_config info Signed-off-by: Ayan Kumar Halder --- .../gpu/drm/arm/display/komeda/komeda_kms.c | 20 +++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/= drm/arm/display/komeda/komeda_kms.c index 89191a555c84..e219d1b67100 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include =20 @@ -304,24 +305,30 @@ struct komeda_kms_dev *komeda_kms_attach(struct komed= a_dev *mdev) komeda_kms_irq_handler, IRQF_SHARED, drm->driver->name, drm); if (err) - goto cleanup_mode_config; + goto free_component_binding; =20 err =3D mdev->funcs->enable_irq(mdev); if (err) - goto cleanup_mode_config; + goto free_component_binding; =20 drm->irq_enabled =3D true; =20 err =3D drm_dev_register(drm, 0); if (err) - goto cleanup_mode_config; + goto free_interrupts; =20 return kms; =20 -cleanup_mode_config: +free_interrupts: drm->irq_enabled =3D false; + mdev->funcs->disable_irq(mdev); +free_component_binding: + component_unbind_all(mdev->dev, drm); +cleanup_mode_config: drm_mode_config_cleanup(drm); komeda_kms_cleanup_private_objs(kms); + drm->dev_private =3D NULL; + drm_dev_put(drm); free_kms: kfree(kms); return ERR_PTR(err); @@ -332,12 +339,13 @@ void komeda_kms_detach(struct komeda_kms_dev *kms) struct drm_device *drm =3D &kms->base; struct komeda_dev *mdev =3D drm->dev_private; =20 + drm_dev_unregister(drm); + drm_atomic_helper_shutdown(drm); drm->irq_enabled =3D false; mdev->funcs->disable_irq(mdev); - drm_dev_unregister(drm); component_unbind_all(mdev->dev, drm); - komeda_kms_cleanup_private_objs(kms); drm_mode_config_cleanup(drm); + komeda_kms_cleanup_private_objs(kms); drm->dev_private =3D NULL; drm_dev_put(drm); } --=20 2.21.0