From: Daniel Vetter Subject: Re: [PATCH 2/4] drm/shmem: Use mutex_trylock in drm_gem_shmem_purge Date: Wed, 21 Aug 2019 10:23:43 +0200 Message-ID: <20190821082343.GJ11147@phenom.ffwll.local> References: <20190819161204.3106-1-robh@kernel.org> <20190819161204.3106-3-robh@kernel.org> <20190820090543.GE11147@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id E901F6E93E for ; Wed, 21 Aug 2019 08:23:47 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id m44so1925404edd.9 for ; Wed, 21 Aug 2019 01:23:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: Maxime Ripard , Tomeu Vizoso , David Airlie , Sean Paul , dri-devel , Steven Price , Boris Brezillon , Robin Murphy List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBBdWcgMjAsIDIwMTkgYXQgMDc6MzU6NDdBTSAtMDUwMCwgUm9iIEhlcnJpbmcgd3Jv dGU6Cj4gT24gVHVlLCBBdWcgMjAsIDIwMTkgYXQgNDowNSBBTSBEYW5pZWwgVmV0dGVyIDxkYW5p ZWxAZmZ3bGwuY2g+IHdyb3RlOgo+ID4KPiA+IE9uIE1vbiwgQXVnIDE5LCAyMDE5IGF0IDExOjEy OjAyQU0gLTA1MDAsIFJvYiBIZXJyaW5nIHdyb3RlOgo+ID4gPiBMb2NrZGVwIHJlcG9ydHMgYSBj aXJjdWxhciBsb2NraW5nIGRlcGVuZGVuY3kgd2l0aCBwYWdlc19sb2NrIHRha2VuIGluCj4gPiA+ IHRoZSBzaHJpbmtlciBjYWxsYmFjay4gVGhlIGRlYWRsb2NrIGNhbid0IGFjdHVhbGx5IGhhcHBl biB3aXRoIGN1cnJlbnQKPiA+ID4gdXNlcnMgYXQgbGVhc3QgYXMgYSBCTyB3aWxsIG5ldmVyIGJl IHB1cmdlYWJsZSB3aGVuIHBhZ2VzX2xvY2sgaXMgaGVsZC4KPiA+ID4gVG8gYmUgc2FmZSwgbGV0 J3MgdXNlIG11dGV4X3RyeWxvY2soKSBpbnN0ZWFkIGFuZCBiYWlsIGlmIGEgQk8gaXMgbG9ja2Vk Cj4gPiA+IGFscmVhZHkuCj4gPiA+Cj4gPiA+IFdBUk5JTkc6IHBvc3NpYmxlIGNpcmN1bGFyIGxv Y2tpbmcgZGVwZW5kZW5jeSBkZXRlY3RlZAo+ID4gPiA1LjMuMC1yYzErICMxMDAgVGFpbnRlZDog RyAgICAgICAgICAgICBMCj4gPiA+IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gPiBrc3dhcGQwLzE3MSBpcyB0cnlpbmcgdG8gYWNxdWly ZSBsb2NrOgo+ID4gPiAwMDAwMDAwMDliOTgyM2ZkICgmc2htZW0tPnBhZ2VzX2xvY2speysuKy59 LCBhdDogZHJtX2dlbV9zaG1lbV9wdXJnZSsweDIwLzB4NDAKPiA+ID4KPiA+ID4gYnV0IHRhc2sg aXMgYWxyZWFkeSBob2xkaW5nIGxvY2s6Cj4gPiA+IDAwMDAwMDAwZjgyMzY5YjYgKGZzX3JlY2xh aW0peysuKy59LCBhdDogX19mc19yZWNsYWltX2FjcXVpcmUrMHgwLzB4NDAKPiA+ID4KPiA+ID4g d2hpY2ggbG9jayBhbHJlYWR5IGRlcGVuZHMgb24gdGhlIG5ldyBsb2NrLgo+ID4gPgo+ID4gPiB0 aGUgZXhpc3RpbmcgZGVwZW5kZW5jeSBjaGFpbiAoaW4gcmV2ZXJzZSBvcmRlcikgaXM6Cj4gPiA+ Cj4gPiA+IC0+ICMxIChmc19yZWNsYWltKXsrLisufToKPiA+ID4gICAgICAgIGZzX3JlY2xhaW1f YWNxdWlyZS5wYXJ0LjE4KzB4MzQvMHg0MAo+ID4gPiAgICAgICAgZnNfcmVjbGFpbV9hY3F1aXJl KzB4MjAvMHgyOAo+ID4gPiAgICAgICAgX19rbWFsbG9jX25vZGUrMHg2Yy8weDRjMAo+ID4gPiAg ICAgICAga3ZtYWxsb2Nfbm9kZSsweDM4LzB4YTgKPiA+ID4gICAgICAgIGRybV9nZW1fZ2V0X3Bh Z2VzKzB4ODAvMHgxZDAKPiA+ID4gICAgICAgIGRybV9nZW1fc2htZW1fZ2V0X3BhZ2VzKzB4NTgv MHhhMAo+ID4gPiAgICAgICAgZHJtX2dlbV9zaG1lbV9nZXRfcGFnZXNfc2d0KzB4NDgvMHhkMAo+ ID4gPiAgICAgICAgcGFuZnJvc3RfbW11X21hcCsweDM4LzB4ZjggW3BhbmZyb3N0XQo+ID4gPiAg ICAgICAgcGFuZnJvc3RfZ2VtX29wZW4rMHhjMC8weGU4IFtwYW5mcm9zdF0KPiA+ID4gICAgICAg IGRybV9nZW1faGFuZGxlX2NyZWF0ZV90YWlsKzB4ZTgvMHgxOTgKPiA+ID4gICAgICAgIGRybV9n ZW1faGFuZGxlX2NyZWF0ZSsweDNjLzB4NTAKPiA+ID4gICAgICAgIHBhbmZyb3N0X2dlbV9jcmVh dGVfd2l0aF9oYW5kbGUrMHg3MC8weGEwIFtwYW5mcm9zdF0KPiA+ID4gICAgICAgIHBhbmZyb3N0 X2lvY3RsX2NyZWF0ZV9ibysweDQ4LzB4ODAgW3BhbmZyb3N0XQo+ID4gPiAgICAgICAgZHJtX2lv Y3RsX2tlcm5lbCsweGI4LzB4MTEwCj4gPiA+ICAgICAgICBkcm1faW9jdGwrMHgyNDQvMHgzZjAK PiA+ID4gICAgICAgIGRvX3Zmc19pb2N0bCsweGJjLzB4OTEwCj4gPiA+ICAgICAgICBrc3lzX2lv Y3RsKzB4NzgvMHhhOAo+ID4gPiAgICAgICAgX19hcm02NF9zeXNfaW9jdGwrMHgxYy8weDI4Cj4g PiA+ICAgICAgICBlbDBfc3ZjX2NvbW1vbi5jb25zdHByb3AuMCsweDkwLzB4MTY4Cj4gPiA+ICAg ICAgICBlbDBfc3ZjX2hhbmRsZXIrMHgyOC8weDc4Cj4gPiA+ICAgICAgICBlbDBfc3ZjKzB4OC8w eGMKPiA+ID4KPiA+ID4gLT4gIzAgKCZzaG1lbS0+cGFnZXNfbG9jayl7Ky4rLn06Cj4gPiA+ICAg ICAgICBfX2xvY2tfYWNxdWlyZSsweGEyYy8weDFkNzAKPiA+ID4gICAgICAgIGxvY2tfYWNxdWly ZSsweGRjLzB4MjI4Cj4gPiA+ICAgICAgICBfX211dGV4X2xvY2srMHg4Yy8weDgwMAo+ID4gPiAg ICAgICAgbXV0ZXhfbG9ja19uZXN0ZWQrMHgxYy8weDI4Cj4gPiA+ICAgICAgICBkcm1fZ2VtX3No bWVtX3B1cmdlKzB4MjAvMHg0MAo+ID4gPiAgICAgICAgcGFuZnJvc3RfZ2VtX3Nocmlua2VyX3Nj YW4rMHhjMC8weDE4MCBbcGFuZnJvc3RdCj4gPiA+ICAgICAgICBkb19zaHJpbmtfc2xhYisweDIw OC8weDUwMAo+ID4gPiAgICAgICAgc2hyaW5rX3NsYWIrMHgxMGMvMHgyYzAKPiA+ID4gICAgICAg IHNocmlua19ub2RlKzB4MjhjLzB4NGQ4Cj4gPiA+ICAgICAgICBiYWxhbmNlX3BnZGF0KzB4MmM4 LzB4NTcwCj4gPiA+ICAgICAgICBrc3dhcGQrMHgyMmMvMHg2MzgKPiA+ID4gICAgICAgIGt0aHJl YWQrMHgxMjgvMHgxMzAKPiA+ID4gICAgICAgIHJldF9mcm9tX2ZvcmsrMHgxMC8weDE4Cj4gPiA+ Cj4gPiA+IG90aGVyIGluZm8gdGhhdCBtaWdodCBoZWxwIHVzIGRlYnVnIHRoaXM6Cj4gPiA+Cj4g PiA+ICBQb3NzaWJsZSB1bnNhZmUgbG9ja2luZyBzY2VuYXJpbzoKPiA+ID4KPiA+ID4gICAgICAg IENQVTAgICAgICAgICAgICAgICAgICAgIENQVTEKPiA+ID4gICAgICAgIC0tLS0gICAgICAgICAg ICAgICAgICAgIC0tLS0KPiA+ID4gICBsb2NrKGZzX3JlY2xhaW0pOwo+ID4gPiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgbG9jaygmc2htZW0tPnBhZ2VzX2xvY2spOwo+ID4gPiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgbG9jayhmc19yZWNsYWltKTsKPiA+ID4gICBsb2Nr KCZzaG1lbS0+cGFnZXNfbG9jayk7Cj4gPiA+Cj4gPiA+ICAqKiogREVBRExPQ0sgKioqCj4gPiA+ Cj4gPiA+IDMgbG9ja3MgaGVsZCBieSBrc3dhcGQwLzE3MToKPiA+ID4gICMwOiAwMDAwMDAwMGY4 MjM2OWI2IChmc19yZWNsYWltKXsrLisufSwgYXQ6IF9fZnNfcmVjbGFpbV9hY3F1aXJlKzB4MC8w eDQwCj4gPiA+ICAjMTogMDAwMDAwMDBjZWIzNzgwOCAoc2hyaW5rZXJfcndzZW0peysrKyt9LCBh dDogc2hyaW5rX3NsYWIrMHhiYy8weDJjMAo+ID4gPiAgIzI6IDAwMDAwMDAwZjMxZWZhODEgKCZw ZmRldi0+c2hyaW5rZXJfbG9jayl7Ky4rLn0sIGF0OiBwYW5mcm9zdF9nZW1fc2hyaW5rZXJfc2Nh bisweDM0LzB4MTgwIFtwYW5mcm9zdF0KPiA+ID4KPiA+ID4gRml4ZXM6IDE3YWNiOWYzNWVkNyAo ImRybS9zaG1lbTogQWRkIG1hZHZpc2Ugc3RhdGUgYW5kIHB1cmdlIGhlbHBlcnMiKQo+ID4gPiBD YzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4K PiA+ID4gQ2M6IE1heGltZSBSaXBhcmQgPG1heGltZS5yaXBhcmRAYm9vdGxpbi5jb20+Cj4gPiA+ IENjOiBTZWFuIFBhdWwgPHNlYW5AcG9vcmx5LnJ1bj4KPiA+ID4gQ2M6IERhdmlkIEFpcmxpZSA8 YWlybGllZEBsaW51eC5pZT4KPiA+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5j aD4KPiA+ID4gU2lnbmVkLW9mZi1ieTogUm9iIEhlcnJpbmcgPHJvYmhAa2VybmVsLm9yZz4KPiA+ ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2dlbV9zaG1lbV9oZWxwZXIuYyB8IDcg KysrKystLQo+ID4gPiAgaW5jbHVkZS9kcm0vZHJtX2dlbV9zaG1lbV9oZWxwZXIuaCAgICAgfCAy ICstCj4gPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMo LSkKPiA+ID4KPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtX3NobWVt X2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9nZW1fc2htZW1faGVscGVyLmMKPiA+ID4g aW5kZXggNTQyM2VjNTZiNTM1Li5mNTkxODcwNzY3MmYgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9kcm1fZ2VtX3NobWVtX2hlbHBlci5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9kcm1fZ2VtX3NobWVtX2hlbHBlci5jCj4gPiA+IEBAIC00MTUsMTMgKzQxNSwxNiBAQCB2 b2lkIGRybV9nZW1fc2htZW1fcHVyZ2VfbG9ja2VkKHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2Jq KQo+ID4gPiAgfQo+ID4gPiAgRVhQT1JUX1NZTUJPTChkcm1fZ2VtX3NobWVtX3B1cmdlX2xvY2tl ZCk7Cj4gPiA+Cj4gPiA+IC12b2lkIGRybV9nZW1fc2htZW1fcHVyZ2Uoc3RydWN0IGRybV9nZW1f b2JqZWN0ICpvYmopCj4gPiA+ICtib29sIGRybV9nZW1fc2htZW1fcHVyZ2Uoc3RydWN0IGRybV9n ZW1fb2JqZWN0ICpvYmopCj4gPiA+ICB7Cj4gPiA+ICAgICAgIHN0cnVjdCBkcm1fZ2VtX3NobWVt X29iamVjdCAqc2htZW0gPSB0b19kcm1fZ2VtX3NobWVtX29iaihvYmopOwo+ID4gPgo+ID4gPiAt ICAgICBtdXRleF9sb2NrKCZzaG1lbS0+cGFnZXNfbG9jayk7Cj4gPiA+ICsgICAgIGlmICghbXV0 ZXhfdHJ5bG9jaygmc2htZW0tPnBhZ2VzX2xvY2spKQo+ID4KPiA+IERpZCB5b3Ugc2VlIG15IHBp bmcgYWJvdXQgY3V0dGluZyBhbGwgdGhlIGxvY2tpbmcgb3ZlciB0byBkbWFfcmVzdj8KPiAKPiBZ ZXMsIGJ1dCB5b3UgZGlkbid0IHJlcGx5IHRvIFJvYiBDLiBhYm91dCBpdC4gSSBndWVzcyBJJ2xs IGhhdmUgdG8gZ28KPiBmaWd1cmUgb3V0IGhvdyByZXNlcnZhdGlvbiBvYmplY3RzIHdvcmsuLi4K Cm1zbSB3YXMgdGhlIGxhc3QgZHJpdmVyIHRoYXQgc3RpbGwgdXNlZCBzdHJ1Y3RfbXV0ZXguIEl0 J3MgYSBsb25nLXRlcm0KZGVhZC1lbmQsIGFuZCBJIHRoaW5rIHdpdGggYWxsIHRoZSBlZmZvcnQg cmVjZW50bHkgdG8gY3JlYXRlIGhlbHBlcnMgZm9yCnJlbmRlcmluZyBkcml2ZXJzIChzaG1lbSwg dnJhbSwgdHRtIHJlZmFjdG9yaW5nKSB3ZSBzaG91bGQgbWFrZSBhIHNvbGlkCmF0dGVtcHQgdG8g Z2V0IGFsaWduZWQuIE9yIGRpZCB5b3UgbWVhbiB0aGF0IFJvYiBDbGFyayBoYWQgc29tZQpyZXBs eS9xdWVzdGlvbnMgdGhhdCBJIGRpZG4nIHJlc3BvbmQgdG8gYmVjYXVzZSBpdCBmZWxsIHRocm91 Z2ggY3JhY2tzPwoKPiA+IFdvdWxkCj4gPiBhbGlnbiBzaG1lbSBoZWxwZXJzIHdpdGggdHRtIGEg bG90IG1vcmUsIGZvciB0aGF0IGJyaWdodCBnbG9yaW91cyBmdXR1cmUKPiA+IHRhc3RlLiBTaG91 bGQgd2UgY2FwdHVyZSB0aGF0IGluIHNvbWUgdG9kby5yc3QgZW50cnk/Cj4gCj4gU3VyZS4KCkNo ZWVycywgRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBD b3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWw=