From: Steven Price Subject: [PATCH] drm/panfrost: Add missing check for pfdev->regulator Date: Thu, 22 Aug 2019 10:32:18 +0100 Message-ID: <20190822093218.26014-1-steven.price@arm.com> References: <20190822091512.GA32661@mwanda> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190822091512.GA32661@mwanda> Sender: linux-kernel-owner@vger.kernel.org To: Daniel Vetter , David Airlie , Rob Herring , Tomeu Vizoso Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Steven Price , Dan Carpenter List-Id: dri-devel@lists.freedesktop.org When modifying panfrost_devfreq_target() to support a device without a regulator defined I missed the check on the error path. Let's add it. Reported-by: Dan Carpenter Fixes: e21dd290881b ("drm/panfrost: Enable devfreq to work without regulator") Signed-off-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c index 710d903f8e0d..a1f5fa6a742a 100644 --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c @@ -53,8 +53,10 @@ static int panfrost_devfreq_target(struct device *dev, unsigned long *freq, if (err) { dev_err(dev, "Cannot set frequency %lu (%d)\n", target_rate, err); - regulator_set_voltage(pfdev->regulator, pfdev->devfreq.cur_volt, - pfdev->devfreq.cur_volt); + if (pfdev->regulator) + regulator_set_voltage(pfdev->regulator, + pfdev->devfreq.cur_volt, + pfdev->devfreq.cur_volt); return err; } -- 2.20.1