Date: Mon, 26 Aug 2019 09:06:07 -0400 From: Vivek Goyal Message-ID: <20190826130607.GB3561@redhat.com> References: <20190821175720.25901-1-vgoyal@redhat.com> <20190821175720.25901-5-vgoyal@redhat.com> <5D63392C.3030404@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5D63392C.3030404@huawei.com> Subject: Re: [Virtio-fs] [PATCH 04/19] virtio: Implement get_shm_region for PCI transport List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: piaojun Cc: kbuild test robot , kvm@vger.kernel.org, miklos@szeredi.hu, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, virtio-fs@redhat.com, Sebastien Boeuf , linux-fsdevel@vger.kernel.org On Mon, Aug 26, 2019 at 09:43:08AM +0800, piaojun wrote: [..] > > +static bool vp_get_shm_region(struct virtio_device *vdev, > > + struct virtio_shm_region *region, u8 id) > > +{ > > + struct virtio_pci_device *vp_dev = to_vp_device(vdev); > > + struct pci_dev *pci_dev = vp_dev->pci_dev; > > + u8 bar; > > + u64 offset, len; > > + phys_addr_t phys_addr; > > + size_t bar_len; > > + char *bar_name; > > 'char *bar_name' should be cleaned up to avoid compiling warning. And I > wonder if you mix tab and blankspace for code indent? Or it's just my > email display problem? Will get rid of now unused bar_name. Generally git flags if there are tab/space issues. I did not see any. So if you see something, point it out and I will fix it. Vivek