From: Tom Rini Date: Mon, 2 Sep 2019 10:13:09 -0400 Subject: [U-Boot] [PATCH 1/3] Revert "blk: Invalidate block cache when switching hwpart" In-Reply-To: <1566891140-1811-1-git-send-email-weijie.gao@mediatek.com> References: <1566891140-1811-1-git-send-email-weijie.gao@mediatek.com> Message-ID: <20190902141309.GR26850@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Aug 27, 2019 at 03:32:18PM +0800, Weijie Gao wrote: > This reverts commit 0ebe112d09b48230ba4be833cd3504b06997d9a4. > > Most block devices have only one hwpart. Multiple hwparts only found used > by eMMC devices in u-boot. The mmc driver do blk_dselect_hwpart() at the > beginning of mmc_bread() which causes block cache being invalidated too > frequently and makes block cache useless. > > So it's not a good idea to put blkcache_invalidate() in the common > functions. It should be called inside mmc_select_hwpart(). > > Signed-off-by: Weijie Gao > Tested-by: Felix Brack Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: