Date: Tue, 3 Sep 2019 10:12:16 -0400 From: "Michael S. Tsirkin" Message-ID: <20190903101001-mutt-send-email-mst@kernel.org> References: <20190821173742.24574-1-vgoyal@redhat.com> <20190903041507-mutt-send-email-mst@kernel.org> <20190903140752.GA10983@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190903140752.GA10983@redhat.com> Subject: Re: [Virtio-fs] [PATCH v3 00/13] virtio-fs: shared file system for virtual machines List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vivek Goyal Cc: Miklos Szeredi , Jason Wang , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-fs@redhat.com, linux-fsdevel@vger.kernel.org On Tue, Sep 03, 2019 at 10:07:52AM -0400, Vivek Goyal wrote: > On Tue, Sep 03, 2019 at 04:31:38AM -0400, Michael S. Tsirkin wrote: > > [..] > > + /* TODO lock */ > > give me pause. > > > > Cleanup generally seems broken to me - what pauses the FS > > I am looking into device removal aspect of it now. Thinking of adding > a reference count to virtiofs device and possibly also a bit flag to > indicate if device is still alive. That way, we should be able to cleanup > device more gracefully. Generally, the way to cleanup things is to first disconnect device from linux so linux won't send new requests, wait for old ones to finish. > > > > What about the rest of TODOs in that file? > > I will also take a closer look at TODOs now. Better device cleanup path > might get rid of some of them. Some of them might not be valid anymore. > > > > > use of usleep is hacky - can't we do better e.g. with a > > completion? > > Agreed. > > Thanks > Vivek