From: Andy Shevchenko Subject: Re: [PATCH v5 11/11] lib/test_printf: Add tests for %pfw printk modifier Date: Wed, 4 Sep 2019 20:22:22 +0300 Message-ID: <20190904172222.GV2680@smile.fi.intel.com> References: <20190902135732.23455-1-sakari.ailus@linux.intel.com> <20190902135732.23455-12-sakari.ailus@linux.intel.com> <20190902161352.GS2680@smile.fi.intel.com> <20190904161051.GX5475@paasikivi.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190904161051.GX5475@paasikivi.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Sakari Ailus Cc: Petr Mladek , linux-kernel@vger.kernel.org, rafael@kernel.org, linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Heikki Krogerus List-Id: devicetree@vger.kernel.org On Wed, Sep 04, 2019 at 07:10:51PM +0300, Sakari Ailus wrote: > On Mon, Sep 02, 2019 at 07:13:52PM +0300, Andy Shevchenko wrote: > > On Mon, Sep 02, 2019 at 04:57:32PM +0300, Sakari Ailus wrote: > > > Add a test for the %pfw printk modifier using software nodes. > > > > > +static void __init fwnode_pointer(void) > > > +{ > > > + const struct software_node softnodes[] = { > > > + { .name = "first", }, > > > + { .name = "second", .parent = &softnodes[0], }, > > > + { .name = "third", .parent = &softnodes[1], }, > > > + { NULL /* Guardian */ }, > > > > Comma is still here :-) > > Oops. I ended up removing the comma in a wrong patch which wasn't submitted > to the list. Will fix for v6. Also you may remove NULL there since it's default. -- With Best Regards, Andy Shevchenko