From: Gabriel Paubert Subject: Re: [PATCH v12 01/12] lib: introduce copy_struct_{to, from}_user helpers Date: Thu, 5 Sep 2019 12:13:15 +0200 Message-ID: <20190905101315.GA25637@lt-gp.iram.es> References: <20190904201933.10736-1-cyphar@cyphar.com> <20190904201933.10736-2-cyphar@cyphar.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5GvbRXZge7ga59VNHzw5YPuNd7RYki/F8t+fMIT5/Fk=; b=ra8Plhx/6ctuoV Qff4p0Pt3AJBl009U5A7g5eqHeZNeuO99fDSGrUGw6PkHB9HIkcJhNr5uidzMUY786oRfgECVTWDl XlMRc8iF3eisk99ppxQSooB+3hd9/XB9heTU1MogskWrjZtOSrLv6KnhYCqHrFIdXGXFzFz/XsNug RcXSj1QjLkNdYfokj0KBMRTOQg+HIytOtaLfEzfkh4elEUZ2QW2MRoE56mxMlIMZYv9NAjhMVvVGf HPQ2L74P9TYcdJAQrN67xJk8C+JOrdboyzqDhRAcMX4Oys3dSfGGgPLuRfs2cXQ62d2xkecrMBfhK kJl6uWcH0kl5GnUjaFkA==; Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andreas Schwab Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , Rasmus Villemoes , Alexei Starovoitov , linux-mips@vger.kernel.org, David Howells , linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, Jiri Olsa , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Tycho Andersen , Aleksa Sarai , Shuah Khan , Alexander Shishkin , Ingo Molnar , Christian Brauner , linux-xtensa@linux-xtensa.org, Kees Cook , Arnd Bergmann , Jann Horn , Oleg Nesterov , Aleksa Sarai , Al Viro , Andy Lutomirski , Shua On Thu, Sep 05, 2019 at 11:09:35AM +0200, Andreas Schwab wrote: > On Sep 05 2019, Aleksa Sarai wrote: > > > diff --git a/lib/struct_user.c b/lib/struct_user.c > > new file mode 100644 > > index 000000000000..7301ab1bbe98 > > --- /dev/null > > +++ b/lib/struct_user.c > > @@ -0,0 +1,182 @@ > > +// SPDX-License-Identifier: GPL-2.0-or-later > > +/* > > + * Copyright (C) 2019 SUSE LLC > > + * Copyright (C) 2019 Aleksa Sarai > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#define BUFFER_SIZE 64 > > + > > +/* > > + * "memset(p, 0, size)" but for user space buffers. Caller must have already > > + * checked access_ok(p, size). > > + */ > > +static int __memzero_user(void __user *p, size_t s) > > +{ > > + const char zeros[BUFFER_SIZE] = {}; > > Perhaps make that static? On SMP? It should at least be per cpu, and I'm not even sure with preemption. Gabriel > > Andreas. > > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > "And now for something completely different."