From: Imre Deak Subject: Re: [PATCH v7 5/7] drm/i915/tgl: DC3CO PSR2 helper Date: Sun, 8 Sep 2019 20:20:14 +0300 Message-ID: <20190908172014.GC28096@ideak-desk.fi.intel.com> References: <20190907171443.16181-1-anshuman.gupta@intel.com> <20190907171443.16181-6-anshuman.gupta@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD5BD897C5 for ; Sun, 8 Sep 2019 17:20:58 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190907171443.16181-6-anshuman.gupta@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Anshuman Gupta Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gU2F0LCBTZXAgMDcsIDIwMTkgYXQgMTA6NDQ6NDFQTSArMDUzMCwgQW5zaHVtYW4gR3VwdGEg d3JvdGU6Cj4gQWRkIGRjM2NvIGhlbHBlciBmdW5jdGlvbnMgdG8gZW5hYmxlL2Rpc2FibGUgcHNy MiBkZWVwIHNsZWVwLgo+IEFkaGVyZSBCLlNwZWNzIGJ5IGRpc2FsbG93IERDM0NPIHN0YXRlIGJl Zm9yZSBQU1IyIGV4aXQuCj4gRW5hYmxlIFBTUjIgZXhpdGxpbmUgZXZlbnQgYW5kIHByb2dyYW0g dGhlIGRlc2lyZWQgc2NhbmxpbmVzCj4gdG8gZXhpdCBEQzNDTyBpbiBpbnRlbF9wc3JfZW5hYmxl IGZ1bmN0aW9uIGF0IG1vZGVzZXQgcGF0aC4KPiBEaXNhYmxlIHRoZSBEQzNDTyBleGl0bGluZSBp biBvcmRlciB0byBtYWludGlhbiBjb25zaXN0ZW50Cj4gcGlwZSBjb25maWcgc3RhdGUgaW4gZW5j b2RlciBkaXNhYmxlIHBhdGguCj4gCj4gdjE6IG1vdmVkIGNhbGxpbmcgb2YgdGdsX2VuYWJsZV9w c3IyX3RyYW5zY29kZXJfZXhpdGxpbmUoKSB0bwo+ICAgICBpbnRlbF9wc3JfZW5hYmxlKCkuIFtJ bXJlXQo+IAo+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IENjOiBJ bXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4gQ2M6IEFuaW1lc2ggTWFubmEgPGFuaW1l c2gubWFubmFAaW50ZWwuY29tPgo+IENjOiBKb3PDqSBSb2JlcnRvIGRlIFNvdXphIDxqb3NlLnNv dXphQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBBbnNodW1hbiBHdXB0YSA8YW5zaHVtYW4u Z3VwdGFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2lu dGVsX3Bzci5jIHwgNTEgKysrKysrKysrKysrKysrKysrKysrKysrCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2Rpc3BsYXkvaW50ZWxfcHNyLmggfCAgMiArCj4gIDIgZmlsZXMgY2hhbmdlZCwgNTMg aW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNw bGF5L2ludGVsX3Bzci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9wc3Iu Ywo+IGluZGV4IGIzYzdlZWY1M2JmMy4uOTViMTI5NDZjNzJhIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfcHNyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9kaXNwbGF5L2ludGVsX3Bzci5jCj4gQEAgLTUzNCw2ICs1MzQsNDggQEAgdHJhbnNj b2Rlcl9oYXNfcHNyMihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gdHJh bnNjb2RlciB0cmFucykKPiAgCQlyZXR1cm4gdHJhbnMgPT0gVFJBTlNDT0RFUl9FRFA7Cj4gIH0K PiAgCj4gK3N0YXRpYyB2b2lkIHBzcjJfcHJvZ3JhbV9pZGxlX2ZyYW1lcyhzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gKwkJCQkgICAgIHUzMiBpZGxlX2ZyYW1lcykKPiArewo+ ICsJdTMyIHZhbDsKPiArCj4gKwlpZGxlX2ZyYW1lcyA8PD0gIEVEUF9QU1IyX0lETEVfRlJBTUVf U0hJRlQ7Cj4gKwl2YWwgPSBJOTE1X1JFQUQoRURQX1BTUjJfQ1RMKGRldl9wcml2LT5wc3IudHJh bnNjb2RlcikpOwo+ICsJdmFsICY9IH5FRFBfUFNSMl9JRExFX0ZSQU1FX01BU0s7Cj4gKwl2YWwg fD0gaWRsZV9mcmFtZXM7Cj4gKwlJOTE1X1dSSVRFKEVEUF9QU1IyX0NUTChkZXZfcHJpdi0+cHNy LnRyYW5zY29kZXIpLCB2YWwpOwo+ICt9Cj4gKwo+ICt2b2lkIHRnbF9wc3IyX2RlZXBfc2xlZXBf ZGlzYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3sKPiArCWludCBp ZGxlX2ZyYW1lcyA9IDA7CgpObyBuZWVkIGZvciB0aGUgYWJvdmUuCgo+ICsKPiArCXBzcjJfcHJv Z3JhbV9pZGxlX2ZyYW1lcyhkZXZfcHJpdiwgaWRsZV9mcmFtZXMpOwo+ICt9Cj4gKwo+ICt2b2lk IHRnbF9wc3IyX2RlZXBfc2xlZXBfZW5hYmxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdikKPiArewo+ICsJaW50IGlkbGVfZnJhbWVzOwo+ICsKPiArCS8qCj4gKwkgKiBMZXQncyB1 c2UgNiBhcyB0aGUgbWluaW11bSB0byBjb3ZlciBhbGwga25vd24gY2FzZXMgaW5jbHVkaW5nIHRo ZQo+ICsJICogb2ZmLWJ5LW9uZSBpc3N1ZSB0aGF0IEhXIGhhcyBpbiBzb21lIGNhc2VzLgo+ICsJ ICovCj4gKwlpZGxlX2ZyYW1lcyA9IG1heCg2LCBkZXZfcHJpdi0+dmJ0LnBzci5pZGxlX2ZyYW1l cyk7Cj4gKwlpZGxlX2ZyYW1lcyA9IG1heChpZGxlX2ZyYW1lcywgZGV2X3ByaXYtPnBzci5zaW5r X3N5bmNfbGF0ZW5jeSArIDEpOwo+ICsJcHNyMl9wcm9ncmFtX2lkbGVfZnJhbWVzKGRldl9wcml2 LCBpZGxlX2ZyYW1lcyk7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIHRnbF9kaXNhbGxvd19kYzNj b19vbl9wc3IyX2V4aXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICt7Cj4g KwlpZiAoIUlTX1RJR0VSTEFLRShkZXZfcHJpdikpCj4gKwkJcmV0dXJuOwo+ICsKPiArCWNhbmNl bF9kZWxheWVkX3dvcmsoJmRldl9wcml2LT5jc3IuaWRsZV93b3JrKTsKClRoaXMgaXMgcmFjeSwg YXMgdGhlIHdvcmsgY291bGQgYmUgc3RpbGwgcnVubmluZyBhdCB0aGlzIHBvaW50LgoKPiArCS8q IEJlZm9yZSBQU1IyIGV4aXQgZGlzYWxsb3cgZGMzY28qLwo+ICsJdGdsX3NldF90YXJnZXRfZGNf c3RhdGUoZGV2X3ByaXYsIERDX1NUQVRFX0VOX1VQVE9fREM2LCB0cnVlKTsKClRoZSB0aGlyZCBk ZWVwX3NsZWVwIHBhcmFtIGlzIG5vdCBuZWVkZWQsIHNpbmNlIHdlIHdhbnQgZGVlcF9zbGVlcCBv bmx5CndpdGggREM2IChhbmQgbm90IHdpdGggREMzY28pLCBidXQgcHJvZ3JhbW1pbmcgZGVlcF9z bGVlcCBpcyBhIFBTUgppbnRlcm5hbCBzdHVmZiwgc28gc2hvdWxkIGJlIGRvbmUgaGVyZSByYXRo ZXIgdGhhbiB0aGUgcG93ZXIgZG9tYWluCmNvZGUuCgo+ICt9Cj4gKwo+ICBzdGF0aWMgYm9vbCBp bnRlbF9wc3IyX2NvbmZpZ192YWxpZChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLAo+ICAJCQkJ ICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICB7Cj4gQEAgLTc5OSw2 ICs4NDEsMTAgQEAgdm9pZCBpbnRlbF9wc3JfZW5hYmxlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxf ZHAsCj4gIAo+ICAJV0FSTl9PTihkZXZfcHJpdi0+ZHJycy5kcCk7Cj4gIAo+ICsJLyogRW5hYmxl IFBTUjIgdHJhbnNjb2RlciBleGl0IGxpbmUgKi8KPiArCWlmIChjcnRjX3N0YXRlLT5oYXNfcHNy MikKPiArCQl0Z2xfZW5hYmxlX3BzcjJfdHJhbnNjb2Rlcl9leGl0bGluZShjcnRjX3N0YXRlKTsK ClRoZSB0cmFuc2NvZGVyIGlzIGVuYWJsZWQgYWxyZWFkeSBhdCB0aGlzIHBvaW50LCBzbyB3ZSBz aG91bGRuJ3QKY2hhbmdlIHRoZSBleGl0IGxpbmUgcmVnLgoKPiArCj4gIAltdXRleF9sb2NrKCZk ZXZfcHJpdi0+cHNyLmxvY2spOwo+ICAKPiAgCWlmICghcHNyX2dsb2JhbF9lbmFibGVkKGRldl9w cml2LT5wc3IuZGVidWcpKSB7Cj4gQEAgLTgyOSw2ICs4NzUsNyBAQCBzdGF0aWMgdm9pZCBpbnRl bF9wc3JfZXhpdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAl9Cj4gIAo+ ICAJaWYgKGRldl9wcml2LT5wc3IucHNyMl9lbmFibGVkKSB7Cj4gKwkJdGdsX2Rpc2FsbG93X2Rj M2NvX29uX3BzcjJfZXhpdChkZXZfcHJpdik7Cj4gIAkJdmFsID0gSTkxNV9SRUFEKEVEUF9QU1Iy X0NUTChkZXZfcHJpdi0+cHNyLnRyYW5zY29kZXIpKTsKPiAgCQlXQVJOX09OKCEodmFsICYgRURQ X1BTUjJfRU5BQkxFKSk7Cj4gIAkJdmFsICY9IH5FRFBfUFNSMl9FTkFCTEU7Cj4gQEAgLTg5NSw2 ICs5NDIsMTAgQEAgdm9pZCBpbnRlbF9wc3JfZGlzYWJsZShzdHJ1Y3QgaW50ZWxfZHAgKmludGVs X2RwLAo+ICAJaWYgKFdBUk5fT04oIUNBTl9QU1IoZGV2X3ByaXYpKSkKPiAgCQlyZXR1cm47Cj4g IAo+ICsJLyogRGlzYWJsZSBQU1IyIHRyYW5zY29kZXIgZXhpdCBsaW5lICovCj4gKwlpZiAob2xk X2NydGNfc3RhdGUtPmhhc19wc3IyKQo+ICsJCXRnbF9kaXNhYmxlX3BzcjJfdHJhbnNjb2Rlcl9l eGl0bGluZShvbGRfY3J0Y19zdGF0ZSk7CgpTaW1pbGFybHksIHRoaXMgaXNuJ3QgdGhlIHJpZ2h0 IHNwb3QgZm9yIGNoYW5naW5nIHRoZSBleGl0IGxpbmUgcmVnLgoKPiArCj4gIAltdXRleF9sb2Nr KCZkZXZfcHJpdi0+cHNyLmxvY2spOwo+ICAKPiAgCWludGVsX3Bzcl9kaXNhYmxlX2xvY2tlZChp bnRlbF9kcCk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50 ZWxfcHNyLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3Bzci5oCj4gaW5k ZXggNDZlNGRlOGI4Y2Q1Li43NWE5ODYyZjM2ZmQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9wc3IuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2Rpc3BsYXkvaW50ZWxfcHNyLmgKPiBAQCAtMzUsNSArMzUsNyBAQCB2b2lkIGludGVsX3Bzcl9z aG9ydF9wdWxzZShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKTsKPiAgaW50IGludGVsX3Bzcl93 YWl0X2Zvcl9pZGxlKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0 ZSwKPiAgCQkJICAgIHUzMiAqb3V0X3ZhbHVlKTsKPiAgYm9vbCBpbnRlbF9wc3JfZW5hYmxlZChz dHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKTsKPiArdm9pZCB0Z2xfcHNyMl9kZWVwX3NsZWVwX2Rp c2FibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiArdm9pZCB0Z2xfcHNy Ml9kZWVwX3NsZWVwX2VuYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ ICAKPiAgI2VuZGlmIC8qIF9fSU5URUxfUFNSX0hfXyAqLwo+IC0tIAo+IDIuMjEuMAo+IApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=