From: Laurent Pinchart Subject: Re: [PATCH] drm/tilcdc: include linux/pinctrl/consumer.h again Date: Tue, 10 Sep 2019 01:35:56 +0300 Message-ID: <20190909223556.GB15652@pendragon.ideasonboard.com> References: <20190909203409.652308-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20190909203409.652308-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Jyri Sarha , David Airlie , Daniel Vetter , Sam Ravnborg , Emil Velikov , Tomi Valkeinen , Alexios Zavras , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Hi Arnd, Thank you for the patch. On Mon, Sep 09, 2019 at 10:33:57PM +0200, Arnd Bergmann wrote: > This was apparently dropped by accident in a recent > cleanup, causing a build failure in some configurations now: > > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:296:12: error: implicit declaration of function 'devm_pinctrl_get_select_default' [-Werror,-Wimplicit-function-declaration] > > Fixes: fcb57664172e ("drm/tilcdc: drop use of drmP.h") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > index 525dc1c0f1c1..9edcdd7f2b96 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include I'd put this before platform_device.h to keep the headers alphabetically ordered. Apart from that, Reviewed-by: Laurent Pinchart > #include > #include -- Regards, Laurent Pinchart