Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 686CFC49ED7 for ; Tue, 10 Sep 2019 16:25:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4300920872 for ; Tue, 10 Sep 2019 16:25:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394171AbfIJQZl (ORCPT ); Tue, 10 Sep 2019 12:25:41 -0400 Received: from orbyte.nwl.cc ([151.80.46.58]:36878 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394155AbfIJQZk (ORCPT ); Tue, 10 Sep 2019 12:25:40 -0400 Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.91) (envelope-from ) id 1i7ixX-0006SN-UV; Tue, 10 Sep 2019 18:25:39 +0200 Date: Tue, 10 Sep 2019 18:25:39 +0200 From: Phil Sutter To: Eric Garver Cc: netfilter-devel@vger.kernel.org, Pablo Neira Ayuso Subject: Re: [PATCH nft] parser_json: fix crash on insert rule to bad references Message-ID: <20190910162539.GJ1378@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Eric Garver , netfilter-devel@vger.kernel.org, Pablo Neira Ayuso References: <20190910134615.11742-1-eric@garver.life> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190910134615.11742-1-eric@garver.life> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Sep 10, 2019 at 09:46:15AM -0400, Eric Garver wrote: > Pass the location via the handle so the error leg in > erec_print_list() can reference it. Applies to invalid references > to tables, chains, and indexes. > > Fixes: 586ad210368b ("libnftables: Implement JSON parser") > Signed-off-by: Eric Garver Also applied, thanks!