Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A66BC49ED7 for ; Fri, 13 Sep 2019 15:35:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0874E20693 for ; Fri, 13 Sep 2019 15:35:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388052AbfIMPfx (ORCPT ); Fri, 13 Sep 2019 11:35:53 -0400 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:55940 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727405AbfIMPfx (ORCPT ); Fri, 13 Sep 2019 11:35:53 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1i8nbx-0003Ry-2c; Fri, 13 Sep 2019 17:35:49 +0200 Date: Fri, 13 Sep 2019 17:35:49 +0200 From: Florian Westphal To: Phil Sutter Cc: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Subject: Re: [nft PATCH] parser_bison: Fix 'exists' keyword on Big Endian Message-ID: <20190913153549.GB10656@breakpoint.cc> References: <20190913153224.486-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190913153224.486-1-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Phil Sutter wrote: > - BYTEORDER_HOST_ENDIAN, 1, buf); > + BYTEORDER_HOST_ENDIAN, > + sizeof(char) * BITS_PER_BYTE, buf); You can omit the sizeof(char), its always 1. Otherwise this loooks good to me.