From: Daniel Vetter Subject: Re: [PATCH] drm: sti: fix W=1 warnings Date: Tue, 17 Sep 2019 14:46:35 +0200 Message-ID: <20190917124635.GP3958@phenom.ffwll.local> References: <20190909101254.24191-1-benjamin.gaignard@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1A3626EC36 for ; Tue, 17 Sep 2019 12:46:40 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id p10so1391474edq.1 for ; Tue, 17 Sep 2019 05:46:40 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Benjamin Gaignard , Dave Airlie , Maarten Lankhorst , Sean Paul , Maxime Ripard Cc: David Airlie , ML dri-devel , Benjamin Gaignard , Linux Kernel Mailing List List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBTZXAgMTYsIDIwMTkgYXQgMDM6MTY6NDlQTSArMDIwMCwgQmVuamFtaW4gR2FpZ25h cmQgd3JvdGU6Cj4gTGUgbHVuLiA5IHNlcHQuIDIwMTkgw6AgMTI6MjksIEJlbmphbWluIEdhaWdu YXJkCj4gPGJlbmphbWluLmdhaWduYXJkQHN0LmNvbT4gYSDDqWNyaXQgOgo+ID4KPiA+IEZpeCB3 YXJuaW5ncyB3aGVuIFc9MS4KPiA+IE5vIGNvZGUgY2hhbmdlcywgb25seSBjbGVhbiB1cCBpbiBz dGkgaW50ZXJuYWwgc3RydWN0dXJlcyBhbmQgZnVuY3Rpb25zCj4gPiBkZXNjcmlwdGlvbnMuCj4g Pgo+ID4gU2lnbmVkLW9mZi1ieTogQmVuamFtaW4gR2FpZ25hcmQgPGJlbmphbWluLmdhaWduYXJk QHN0LmNvbT4KPiAKPiBGb3IgbXkgb3duIHJlZmVyZW5jZSwgYXBwbGllZCBvbiBkcm0tbWlzYy1u ZXh0CgpEdWRlIHNlcmlvdXNseSBubzoKClNpZ25lZC1vZmYtYnk6IEJlbmphbWluIEdhaWduYXJk IDxiZW5qYW1pbi5nYWlnbmFyZEBzdC5jb20+ClJldmlld2VkLWJ5OiBCZW5qYW1pbiBHYWlnbmFy ZCA8YmVuamFtaW4uZ2FpZ25hcmRAc3QuY29tPgpTaWduZWQtb2ZmLWJ5OiBCZW5qYW1pbiBHYWln bmFyZCA8YmVuamFtaW4uZ2FpZ25hcmRAbGluYXJvLm9yZz4KTGluazogaHR0cHM6Ly9wYXRjaHdv cmsuZnJlZWRlc2t0b3Aub3JnL3BhdGNoL21zZ2lkLzIwMTkwOTA5MTAxMjU0LjI0MTkxLTEtYmVu amFtaW4uZ2FpZ25hcmRAc3QuY29tCgpTZWxmLXJldmlldyBhaW4ndCBvayBpbiBkcm0tbWlzYywg eW91IG5lZWQgc29tZW9uZSB0bwphY2svZG91YmxlLWNoZWNrL2hhdmUgYSBsb29rLiBBbmQgZ2l2 ZW4gdGhhdCB5b3UgaGFkIHRvIGZhYnJpY2F0ZSB5b3VyCnNlbGYtcmV2aWV3IHlvdXJzZWxmIHNv bWVob3cgKHRoZSB0b29scyByZWFsbHkgZG9uJ3QgZG8gdGhhdCBmb3IgeW91KSB0aGlzCmRvZXNu J3QgbG9vayBsaWtlIGFuIGFjY2lkZW50LgoKQWRkaW5nIG90aGVyIG1haW50YWluZXJzLgotRGFu aWVsCgo+IAo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfY3Vyc29yLmMgfCAg MiArLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2R2by5jICAgIHwgIDIgKy0KPiA+ICBk cml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9nZHAuYyAgICB8ICAyICstCj4gPiAgZHJpdmVycy9ncHUv ZHJtL3N0aS9zdGlfaGRhLmMgICAgfCAgMiArLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9zdGkvc3Rp X2hkbWkuYyAgIHwgIDQgKystLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX3R2b3V0LmMg IHwgMTAgKysrKystLS0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX3Z0Zy5jICAgIHwg IDIgKy0KPiA+ICA3IGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9u cygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9jdXJzb3Iu YyBiL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2N1cnNvci5jCj4gPiBpbmRleCAwYmY3YzMzMmNm MGIuLmVhNjRjMWRjYWY2MyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3Rp X2N1cnNvci5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9jdXJzb3IuYwo+ID4g QEAgLTQ3LDcgKzQ3LDcgQEAgc3RydWN0IGRtYV9waXhtYXAgewo+ID4gICAgICAgICB2b2lkICpi YXNlOwo+ID4gIH07Cj4gPgo+ID4gLS8qKgo+ID4gKy8qCj4gPiAgICogU1RJIEN1cnNvciBzdHJ1 Y3R1cmUKPiA+ICAgKgo+ID4gICAqIEBzdGlfcGxhbmU6ICAgIHN0aV9wbGFuZSBzdHJ1Y3R1cmUK PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9kdm8uYyBiL2RyaXZlcnMv Z3B1L2RybS9zdGkvc3RpX2R2by5jCj4gPiBpbmRleCA5ZTZkNWQ4YjcwMzAuLmMzM2QwYWFlZTgy YiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2R2by5jCj4gPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9kdm8uYwo+ID4gQEAgLTY1LDcgKzY1LDcgQEAgc3Rh dGljIHN0cnVjdCBkdm9fY29uZmlnIHJnYl8yNGJpdF9kZV9jZmcgPSB7Cj4gPiAgICAgICAgIC5h d2dfZndnZW5fZmN0ID0gc3RpX2F3Z19nZW5lcmF0ZV9jb2RlX2RhdGFfZW5hYmxlX21vZGUsCj4g PiAgfTsKPiA+Cj4gPiAtLyoqCj4gPiArLyoKPiA+ICAgKiBTVEkgZGlnaXRhbCB2aWRlbyBvdXRw dXQgc3RydWN0dXJlCj4gPiAgICoKPiA+ICAgKiBAZGV2OiBkcml2ZXIgZGV2aWNlCj4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfZ2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0v c3RpL3N0aV9nZHAuYwo+ID4gaW5kZXggOGU5MjZjZDZhMWM4Li4xMTU5NWM3NDg4NDQgMTAwNjQ0 Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV9nZHAuYwo+ID4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL3N0aS9zdGlfZ2RwLmMKPiA+IEBAIC0xMDMsNyArMTAzLDcgQEAgc3RydWN0IHN0 aV9nZHBfbm9kZV9saXN0IHsKPiA+ICAgICAgICAgZG1hX2FkZHJfdCBidG1fZmllbGRfcGFkZHI7 Cj4gPiAgfTsKPiA+Cj4gPiAtLyoqCj4gPiArLyoKPiA+ICAgKiBTVEkgR0RQIHN0cnVjdHVyZQo+ ID4gICAqCj4gPiAgICogQHN0aV9wbGFuZTogICAgICAgICAgc3RpX3BsYW5lIHN0cnVjdHVyZQo+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2hkYS5jIGIvZHJpdmVycy9n cHUvZHJtL3N0aS9zdGlfaGRhLmMKPiA+IGluZGV4IDk0ZTQwNGYxMzIzNC4uMzUxMmE5NGEwZmNh IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfaGRhLmMKPiA+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2hkYS5jCj4gPiBAQCAtMjMwLDcgKzIzMCw3IEBAIHN0 YXRpYyBjb25zdCBzdHJ1Y3Qgc3RpX2hkYV92aWRlb19jb25maWcgaGRhX3N1cHBvcnRlZF9tb2Rl c1tdID0gewo+ID4gICAgICAgICAgQVdHaV83MjB4NDgwcF82MCwgTk5fNzIweDQ4MHBfNjAsIFZJ RF9FRH0KPiA+ICB9Owo+ID4KPiA+IC0vKioKPiA+ICsvKgo+ID4gICAqIFNUSSBoZCBhbmFsb2cg c3RydWN0dXJlCj4gPiAgICoKPiA+ICAgKiBAZGV2OiBkcml2ZXIgZGV2aWNlCj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlfaGRtaS5jIGIvZHJpdmVycy9ncHUvZHJtL3N0 aS9zdGlfaGRtaS5jCj4gPiBpbmRleCBmMDNkNjE3ZWRjNGMuLjg3ZTM0ZjdhNmNmZSAxMDA2NDQK PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2hkbWkuYwo+ID4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL3N0aS9zdGlfaGRtaS5jCj4gPiBAQCAtMzMzLDcgKzMzMyw2IEBAIHN0YXRpYyB2 b2lkIGhkbWlfaW5mb2ZyYW1lX3Jlc2V0KHN0cnVjdCBzdGlfaGRtaSAqaGRtaSwKPiA+ICAgKiBI ZWxwZXIgdG8gY29uY2F0ZW5hdGUgaW5mb2ZyYW1lIGluIDMyIGJpdHMgd29yZAo+ID4gICAqCj4g PiAgICogQHB0cjogcG9pbnRlciBvbiB0aGUgaGRtaSBpbnRlcm5hbCBzdHJ1Y3R1cmUKPiA+IC0g KiBAZGF0YTogaW5mb2ZyYW1lIHRvIHdyaXRlCj4gPiAgICogQHNpemU6IHNpemUgdG8gd3JpdGUK PiA+ICAgKi8KPiA+ICBzdGF0aWMgaW5saW5lIHVuc2lnbmVkIGludCBoZG1pX2luZm9mcmFtZV9z dWJwYWNrKGNvbnN0IHU4ICpwdHIsIHNpemVfdCBzaXplKQo+ID4gQEAgLTU0MywxMyArNTQyLDE0 IEBAIHN0YXRpYyBpbnQgaGRtaV92ZW5kb3JfaW5mb2ZyYW1lX2NvbmZpZyhzdHJ1Y3Qgc3RpX2hk bWkgKmhkbWkpCj4gPiAgICAgICAgIHJldHVybiAwOwo+ID4gIH0KPiA+Cj4gPiArI2RlZmluZSBI RE1JX1RJTUVPVVRfU1dSRVNFVCAgMTAwICAgLyptaWxsaXNlY29uZHMgKi8KPiA+ICsKPiA+ICAv KioKPiA+ICAgKiBTb2Z0d2FyZSByZXNldCBvZiB0aGUgaGRtaSBzdWJzeXN0ZW0KPiA+ICAgKgo+ ID4gICAqIEBoZG1pOiBwb2ludGVyIG9uIHRoZSBoZG1pIGludGVybmFsIHN0cnVjdHVyZQo+ID4g ICAqCj4gPiAgICovCj4gPiAtI2RlZmluZSBIRE1JX1RJTUVPVVRfU1dSRVNFVCAgMTAwICAgLypt aWxsaXNlY29uZHMgKi8KPiA+ICBzdGF0aWMgdm9pZCBoZG1pX3N3cmVzZXQoc3RydWN0IHN0aV9o ZG1pICpoZG1pKQo+ID4gIHsKPiA+ICAgICAgICAgdTMyIHZhbDsKPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vc3RpL3N0aV90dm91dC5jIGIvZHJpdmVycy9ncHUvZHJtL3N0aS9zdGlf dHZvdXQuYwo+ID4gaW5kZXggZTFiM2M4Y2I3Mjg3Li5iMWZjNzdiMTUwZGEgMTAwNjQ0Cj4gPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV90dm91dC5jCj4gPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vc3RpL3N0aV90dm91dC5jCj4gPiBAQCAtMTU3LDkgKzE1Nyw5IEBAIHN0YXRpYyB2b2lk IHR2b3V0X3dyaXRlKHN0cnVjdCBzdGlfdHZvdXQgKnR2b3V0LCB1MzIgdmFsLCBpbnQgb2Zmc2V0 KQo+ID4gICAqCj4gPiAgICogQHR2b3V0OiB0dm91dCBzdHJ1Y3R1cmUKPiA+ICAgKiBAcmVnOiBy ZWdpc3RlciB0byBzZXQKPiA+IC0gKiBAY3JfcjoKPiA+IC0gKiBAeV9nOgo+ID4gLSAqIEBjYl9i Ogo+ID4gKyAqIEBjcl9yOiByZWQgY2hyb21hIG9yIHJlZCBvcmRlcgo+ID4gKyAqIEB5X2c6IHkg b3IgZ3JlZW4gb3JkZXIKPiA+ICsgKiBAY2JfYjogYmx1ZSBjaHJvbWEgb3IgYmx1ZSBvcmRlcgo+ ID4gICAqLwo+ID4gIHN0YXRpYyB2b2lkIHR2b3V0X3ZpcF9zZXRfY29sb3Jfb3JkZXIoc3RydWN0 IHN0aV90dm91dCAqdHZvdXQsIGludCByZWcsCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHUzMiBjcl9yLCB1MzIgeV9nLCB1MzIgY2JfYikKPiA+IEBAIC0yMTQsNyAr MjE0LDcgQEAgc3RhdGljIHZvaWQgdHZvdXRfdmlwX3NldF9ybmQoc3RydWN0IHN0aV90dm91dCAq dHZvdXQsIGludCByZWcsIHUzMiBybmQpCj4gPiAgICogQHR2b3V0OiB0dm91dCBzdHJ1Y3R1cmUK PiA+ICAgKiBAcmVnOiByZWdpc3RlciB0byBzZXQKPiA+ICAgKiBAbWFpbl9wYXRoOiBtYWluIG9y IGF1eGlsaWFyeSBwYXRoCj4gPiAtICogQHNlbF9pbnB1dDogc2VsZWN0ZWRfaW5wdXQgKG1haW4v YXV4ICsgY29udikKPiA+ICsgKiBAdmlkZW9fb3V0OiBzZWxlY3RlZF9pbnB1dCAobWFpbi9hdXgg KyBjb252KQo+ID4gICAqLwo+ID4gIHN0YXRpYyB2b2lkIHR2b3V0X3ZpcF9zZXRfc2VsX2lucHV0 KHN0cnVjdCBzdGlfdHZvdXQgKnR2b3V0LAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgaW50IHJlZywKPiA+IEBAIC0yNTEsNyArMjUxLDcgQEAgc3RhdGljIHZvaWQgdHZv dXRfdmlwX3NldF9zZWxfaW5wdXQoc3RydWN0IHN0aV90dm91dCAqdHZvdXQsCj4gPiAgICoKPiA+ ICAgKiBAdHZvdXQ6IHR2b3V0IHN0cnVjdHVyZQo+ID4gICAqIEByZWc6IHJlZ2lzdGVyIHRvIHNl dAo+ID4gLSAqIEBpbl92aWRfc2lnbmVkOiB1c2VkIHZpZGVvIGlucHV0IGZvcm1hdAo+ID4gKyAq IEBpbl92aWRfZm10OiB1c2VkIHZpZGVvIGlucHV0IGZvcm1hdAo+ID4gICAqLwo+ID4gIHN0YXRp YyB2b2lkIHR2b3V0X3ZpcF9zZXRfaW5fdmlkX2ZtdChzdHJ1Y3Qgc3RpX3R2b3V0ICp0dm91dCwK PiA+ICAgICAgICAgICAgICAgICBpbnQgcmVnLCB1MzIgaW5fdmlkX2ZtdCkKPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vc3RpL3N0aV92dGcuYyBiL2RyaXZlcnMvZ3B1L2RybS9zdGkv c3RpX3Z0Zy5jCj4gPiBpbmRleCBlZjQwMDlmMTEzOTYuLjBiMTdhYzhhM2ZhYSAxMDA2NDQKPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX3Z0Zy5jCj4gPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vc3RpL3N0aV92dGcuYwo+ID4gQEAgLTEyMSw3ICsxMjEsNyBAQCBzdHJ1Y3Qgc3RpX3Z0 Z19zeW5jX3BhcmFtcyB7Cj4gPiAgICAgICAgIHUzMiB2c3luY19vZmZfYm90Owo+ID4gIH07Cj4g Pgo+ID4gLS8qKgo+ID4gKy8qCj4gPiAgICogU1RJIFZURyBzdHJ1Y3R1cmUKPiA+ICAgKgo+ID4g ICAqIEByZWdzOiByZWdpc3RlciBtYXBwaW5nCj4gPiAtLQo+ID4gMi4xNS4wCj4gPgoKLS0gCkRh bmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9i bG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bA==