Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iAFfJ-0005ZE-GZ for mharc-grub-devel@gnu.org; Tue, 17 Sep 2019 11:45:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37026) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAFfG-0005W1-3r for grub-devel@gnu.org; Tue, 17 Sep 2019 11:45:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iAFfD-0004sm-IJ for grub-devel@gnu.org; Tue, 17 Sep 2019 11:45:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50264) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iAFfD-0004s9-D9 for grub-devel@gnu.org; Tue, 17 Sep 2019 11:45:11 -0400 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E9218C049D59 for ; Tue, 17 Sep 2019 15:45:09 +0000 (UTC) Received: by mail-wm1-f69.google.com with SMTP id 4so1029104wmj.6 for ; Tue, 17 Sep 2019 08:45:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6ebcGHVCD/f8L8ec4r/x8i4XYg4o1HMTvCYFzlWGjEc=; b=dn/tEvF55G8lXZe2YpyHExjmeQkCEA//15ird9D0jabxBfdAb8DDbhDaqlynzZoqwH GlzjxAALiSswGgVsI3gE7XdzaEF5Oopr+/mLu+ixpBAx1/5Kfp19nLJH+h3aI1hY0sFr 2pHLmnZm7yN2UN6YzagXTL4EsQHkI9t8+iPsxn1lA1bV2DdoeswhcYFYftqsoGAdE2jF zMLu8TTEcJoO0JpiWXFrhRZkfKi+M2Xxj+DmrOAfy5mpzDADLj+6cm66Tn9OM9E7/gCc v3enRpav4hrqEgEqI46lWj2BRj/+tBpbXNBFYB4exBDfOpw88p97CTgjJrHLBKKL3MZk onYA== X-Gm-Message-State: APjAAAVyNqB1HfsfTi31+hSflSfK6Q2Fvk7ZJsffmUFXCW62jmDAL4JA 02auMRvpFYN/X9c0/G9IT9H4Sp6tEx2gDDjAy7tQyg9aY8sexY97rdxIAwiWCHfR77CrihP0BEO YrQoKDnpL1u8= X-Received: by 2002:adf:f502:: with SMTP id q2mr3285506wro.186.1568735108452; Tue, 17 Sep 2019 08:45:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqzH3C1WwnW/CdszhG+cRCforgM4LWWnjS5s6+Zqn5+HbBPD0sODGkn2FJw+M2d2E1/cY43DmQ== X-Received: by 2002:adf:f502:: with SMTP id q2mr3285491wro.186.1568735108272; Tue, 17 Sep 2019 08:45:08 -0700 (PDT) Received: from minerva.redhat.com ([90.168.169.92]) by smtp.gmail.com with ESMTPSA id c6sm3814159wrb.60.2019.09.17.08.45.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2019 08:45:07 -0700 (PDT) From: Javier Martinez Canillas To: grub-devel@gnu.org Cc: Gustavo Luiz Duarte , Javier Martinez Canillas , Vladimir Serbinenko , Daniel Kiper Subject: [PATCH] Fix crash on http Date: Tue, 17 Sep 2019 17:44:58 +0200 Message-Id: <20190917154458.31932-1-javierm@redhat.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 15:45:15 -0000 From: Gustavo Luiz Duarte Don't free file->data on receiving FIN flag since it is used all over without checking. http_close() will be called later to free that memory. https://bugzilla.redhat.com/show_bug.cgi?id=3D860834 Signed-off-by: Gustavo Luiz Duarte Signed-off-by: Javier Martinez Canillas --- grub-core/net/http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/net/http.c b/grub-core/net/http.c index 5aa4ad3befc..ec3647f9a0c 100644 --- a/grub-core/net/http.c +++ b/grub-core/net/http.c @@ -392,7 +392,7 @@ http_establish (struct grub_file *file, grub_off_t of= fset, int initial) =20 data->sock =3D grub_net_tcp_open (file->device->net->server, HTTP_PORT, http_receive, - http_err, http_err, + http_err, NULL, file); if (!data->sock) { --=20 2.21.0